You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/03/10 12:09:50 UTC

[GitHub] [guacamole-server] necouchman commented on a change in pull request #335: GUACAMOLE-1307: Use VerifyCertificateEx callback if supported.

necouchman commented on a change in pull request #335:
URL: https://github.com/apache/guacamole-server/pull/335#discussion_r591424574



##########
File path: configure.ac
##########
@@ -897,6 +897,14 @@ then
                      [[#include <freerdp/freerdp.h>]])
 fi
 
+# Updated certificate verification callback (introduced with 2.0.0, not present
+# in 2.0.0-rc4 or earlier)
+if test "x${have_freerdp2}" = "xyes"
+then
+    AC_CHECK_MEMBERS([freerdp.VerifyCertificateEx],,,
+                     [[#include <freerdp/freerdp.h>]])
+fi
+

Review comment:
       Is `HAVE_FREERDP_VERIFYCERTIFICATEEX` defined in the `freerdp/freerdp.h` file? Or does `AC_CHECK_MEMBERS` do some sort of automatic definition? I was looking at the other instances of `AC_CHECK_MEMBERS` in `configure.ac` and they seem to at least have an `AC_DEFINE` call, if not a block of code that works through it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org