You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/06 21:44:50 UTC

[GitHub] [airflow] IAL32 commented on a diff in pull request #28139: Migrate amazon provider sensor tests from `unittests` to `pytest`

IAL32 commented on code in PR #28139:
URL: https://github.com/apache/airflow/pull/28139#discussion_r1041490252


##########
tests/providers/amazon/aws/sensors/test_batch.py:
##########
@@ -44,45 +42,38 @@ def setUp(self):
     @mock.patch.object(BatchClientHook, "get_job_description")
     def test_poke_on_success_state(self, mock_get_job_description):
         mock_get_job_description.return_value = {"status": "SUCCEEDED"}
-        self.assertTrue(self.batch_sensor.poke({}))
+        assert self.batch_sensor.poke({})

Review Comment:
   Ahhh dang.
   I included this change here: https://github.com/apache/airflow/pull/28145/commits/9960d4325c4f98e807b4019625a566cfb26db18c



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org