You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/03/14 12:31:26 UTC
Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
This addresses bug CLOUDSTACK-1668.
Diffs
-----
server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
utils/src/com/cloud/utils/net/NetUtils.java 1341338
Diff: https://reviews.apache.org/r/9923/diff/
Testing
-------
Testing manually ok in VPC tier and non-VPC network.
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review18121
-----------------------------------------------------------
Commit 86a2a7504693e2672552fa98b90a60f9fea30196 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=86a2a75 ]
CLOUDSTACK-1668: Fix IP conflict in VPC tier
Currently, allPossibleIps return the Ip lists which include the gateway,
so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr
return the Ip lists which do not include the first IP of the network
(like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can
be used for VM if it is not the gateway IP (for example, VPC networks).
The corresponding patch for 4.0.1 has been posted on
https://reviews.apache.org/r/9923/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 14, 2013, 8:41 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Description
> -------
>
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
>
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
> We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
>
>
> This addresses bug CLOUDSTACK-1668.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
> utils/src/com/cloud/utils/net/NetUtils.java 1341338
>
> Diff: https://reviews.apache.org/r/9923/diff/
>
>
> Testing
> -------
>
> Testing manually ok in VPC tier and non-VPC network.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review18124
-----------------------------------------------------------
Commit af0723e9c9259619c2cb5d77396e2297f1273a5e in branch refs/heads/4.0 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=af0723e ]
CLOUDSTACK-1668: Fix IP conflict in VPC tier
Currently, allPossibleIps return the Ip lists which include the gateway,
so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr
return the Ip lists which do not include the first IP of the network
(like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can
be used for VM if it is not the gateway IP (for example, VPC networks).
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 14, 2013, 8:41 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Description
> -------
>
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
>
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
> We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
>
>
> This addresses bug CLOUDSTACK-1668.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
> utils/src/com/cloud/utils/net/NetUtils.java 1341338
>
> Diff: https://reviews.apache.org/r/9923/diff/
>
>
> Testing
> -------
>
> Testing manually ok in VPC tier and non-VPC network.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review18125
-----------------------------------------------------------
Ship it!
Committed. Thanks for the patch!
- Chip Childers
On March 14, 2013, 8:41 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Description
> -------
>
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
>
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
> We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
>
>
> This addresses bug CLOUDSTACK-1668.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
> utils/src/com/cloud/utils/net/NetUtils.java 1341338
>
> Diff: https://reviews.apache.org/r/9923/diff/
>
>
> Testing
> -------
>
> Testing manually ok in VPC tier and non-VPC network.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review18120
-----------------------------------------------------------
Commit 0ce1d4fde1fb9e68ed83a9e094133701abbee291 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=0ce1d4f ]
CLOUDSTACK-1668: Fix IP conflict in VPC tier
Currently, allPossibleIps return the Ip lists which include the gateway,
so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr
return the Ip lists which do not include the first IP of the network
(like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can
be used for VM if it is not the gateway IP (for example, VPC networks).
The corresponding patch for 4.0.1 has been posted on
https://reviews.apache.org/r/9923/
Signed-off-by: Chip Childers <ch...@gmail.com>
- ASF Subversion and Git Services
On March 14, 2013, 8:41 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 8:41 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Description
> -------
>
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
>
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
> We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
>
>
> This addresses bug CLOUDSTACK-1668.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
> utils/src/com/cloud/utils/net/NetUtils.java 1341338
>
> Diff: https://reviews.apache.org/r/9923/diff/
>
>
> Testing
> -------
>
> Testing manually ok in VPC tier and non-VPC network.
>
>
> Thanks,
>
> Wei Zhou
>
>
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/
-----------------------------------------------------------
(Updated March 14, 2013, 8:41 p.m.)
Review request for cloudstack and Kishan Kavala.
Description
-------
Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
This addresses bug CLOUDSTACK-1668.
Diffs
-----
server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
utils/src/com/cloud/utils/net/NetUtils.java 1341338
Diff: https://reviews.apache.org/r/9923/diff/
Testing
-------
Testing manually ok in VPC tier and non-VPC network.
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/
-----------------------------------------------------------
(Updated March 14, 2013, 1:30 p.m.)
Review request for cloudstack.
Changes
-------
remove a line
Description
-------
Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
This addresses bug CLOUDSTACK-1668.
Diffs (updated)
-----
server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
utils/src/com/cloud/utils/net/NetUtils.java 1341338
Diff: https://reviews.apache.org/r/9923/diff/
Testing
-------
Testing manually ok in VPC tier and non-VPC network.
Thanks,
Wei Zhou
Re: Review Request: (CLOUDSTACK-1668) Fix IP conflict in VPC tier
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9923/#review17871
-----------------------------------------------------------
server/src/com/cloud/network/NetworkManagerImpl.java
<https://reviews.apache.org/r/9923/#comment37838>
white spaces needs to be removed
- Rajesh Battala
On March 14, 2013, 11:31 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9923/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 11:31 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list.
>
> Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1).
> We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks).
>
>
> This addresses bug CLOUDSTACK-1668.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java b33c52b
> utils/src/com/cloud/utils/net/NetUtils.java 1341338
>
> Diff: https://reviews.apache.org/r/9923/diff/
>
>
> Testing
> -------
>
> Testing manually ok in VPC tier and non-VPC network.
>
>
> Thanks,
>
> Wei Zhou
>
>