[jira] [Commented] (TIKA-1137) Wasted work in WontBeSerializedError.writeObject()

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362156#comment-14362156 ] 

Hudson commented on TIKA-1137:
------------------------------

SUCCESS: Integrated in tika-trunk-jdk1.7 #552 (See [https://builds.apache.org/job/tika-trunk-jdk1.7/552/])
TIKA-1137. Break early when possible in ForkParserIntegrationTest, contributed by Adrian Nistor. (tpalsulich: http://svn.apache.org/viewvc/tika/trunk/?view=rev&rev=1666770)
* /tika/trunk/tika-parsers/src/test/java/org/apache/tika/parser/fork/ForkParserIntegrationTest.java


> Wasted work in WontBeSerializedError.writeObject()
> --------------------------------------------------
>
>                 Key: TIKA-1137
>                 URL: https://issues.apache.org/jira/browse/TIKA-1137
>             Project: Tika
>          Issue Type: Bug
>          Components: parser
>    Affects Versions: 1.3
>         Environment: any
>            Reporter: Adrian Nistor
>            Assignee: Tyler Palsulich
>              Labels: patch, perfomance
>         Attachments: patch.diff
>
>
> The problem appears in version 1.3 and in revision 1494353.  I
> attached a one-line patch that fixes it.
> In method "WontBeSerializedError.writeObject", the loop over
> "e.getStackTrace()" should break immediately after "found" is set to
> "true".  All the iterations after "found" is set to "true" do not
> perform any useful work, at best they just set "found" again to
> "true".
> Method "embedInTempFile" in class "ExternalEmbedderTest" has a similar
> loop (over "embeddedMetadata.getValues(metadataName)"), and this loop
> breaks immediately after "foundExpectedValue" is set to "true", just
> like in the proposed patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)