You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/13 07:28:09 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #23317: Add dag configuration warning for missing pools

potiuk commented on code in PR #23317:
URL: https://github.com/apache/airflow/pull/23317#discussion_r895405933


##########
airflow/dag_processing/processor.py:
##########
@@ -559,6 +560,28 @@ def update_import_errors(session: Session, dagbag: DagBag) -> None:
 
         session.commit()
 
+    @staticmethod
+    def process_dag_warnings(session: Session, dagbag: DagBag) -> None:
+        """
+        For the DAGs in the given DagBag, record any associated configuration warnings and clear
+        warnings for files that no longer have them. These are usually displayed through the
+        Airflow UI so that users know that there are issues parsing DAGs.
+
+        :param session: session for ORM operations
+        :param dagbag: DagBag containing DAGs with configuration warnings
+        """
+        stored_config_warnings = set(session.query(DagWarning).all())

Review Comment:
   Yeah. Agree that optimization here is likely premature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org