You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/07 18:31:42 UTC
[GitHub] [pulsar] tjiuming opened a new pull request, #15965: [monitoring] migrate ManagedCursor metrics to Prometheus
tjiuming opened a new pull request, #15965:
URL: https://github.com/apache/pulsar/pull/15965
### Motivation
migrate ManagedCursor metrics to Prometheus
### Modifications
Reimplement `ManagedCursorMXBean` by `Prometheus`
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1179639127
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [monitoring][modify] migrate ManagedCursor metrics to Prometheus [pulsar]
Posted by "dao-jun (via GitHub)" <gi...@apache.org>.
dao-jun closed pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
URL: https://github.com/apache/pulsar/pull/15965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1228923072
@codelipenghui - do you mind posting a link to the mailing list discussion you're referencing? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by "poorbarcode (via GitHub)" <gi...@apache.org>.
poorbarcode commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1501580835
Since we will start the RC version of `3.0.0` on `2023-04-11`, I will change the label/milestone of PR who have not been merged.
- The PR of type `feature` is deferred to `3.1.0`
- The PR of type `fix` is deferred to `3.0.1`
So drag this PR to `3.1.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1150567387
@tjiuming Please also add the mailing list discussion link, it will help reviewers to understand why we need to do such change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1258877693
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on a diff in pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#discussion_r893121350
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -231,12 +230,6 @@ private static void generateBrokerBasicMetrics(PulsarService pulsar, SimpleTextO
clusterName, Collector.Type.GAUGE, stream);
}
- if (pulsar.getConfiguration().isExposeManagedCursorMetricsInPrometheus()) {
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#issuecomment-1150729186
> @tjiuming Please also add the mailing list discussion link, it will help reviewers to understand why we need to do such change
@codelipenghui Do I need to send a new discuss to community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a diff in pull request #15965: [monitoring][modify] migrate ManagedCursor metrics to Prometheus
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on code in PR #15965:
URL: https://github.com/apache/pulsar/pull/15965#discussion_r892377576
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -231,12 +230,6 @@ private static void generateBrokerBasicMetrics(PulsarService pulsar, SimpleTextO
clusterName, Collector.Type.GAUGE, stream);
}
- if (pulsar.getConfiguration().isExposeManagedCursorMetricsInPrometheus()) {
Review Comment:
If using the Prometheus class to collect metrics, the metrics data will record automatically, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org