You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by ma...@gmail.com on 2010/07/13 20:17:57 UTC

[SHINDIG-1382] Disable HttpClient cookie handling (issue1825042)

Reviewers: henry.saputra, hceylan_batoo.org,  
dev-remailer_shindig.apache.org,



Please review this at http://codereview.appspot.com/1825042/show

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java


Index:  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java
===================================================================
---  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java	 
(revision 963805)
+++  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java	 
(working copy)
@@ -43,6 +43,8 @@
  import org.apache.http.client.methods.HttpUriRequest;
  import org.apache.http.client.params.ClientPNames;
  import org.apache.http.client.params.HttpClientParams;
+import org.apache.http.client.protocol.RequestAddCookies;
+import org.apache.http.client.protocol.ResponseProcessCookies;
  import org.apache.http.conn.ClientConnectionManager;
  import org.apache.http.conn.ConnectionPoolTimeoutException;
  import org.apache.http.conn.HttpHostConnectException;
@@ -212,6 +214,10 @@
      });
      client.setHttpRequestRetryHandler(new DefaultHttpRequestRetryHandler()  
);

+    // SHINDIG-1382 Disable automatic storage and sending of cookies
+    client.removeRequestInterceptorByClass(RequestAddCookies.class);
+    client.removeResponseInterceptorByClass(ResponseProcessCookies.class);
+
      // Use Java's built-in proxy logic in case no proxy set via guice.
      if (StringUtils.isEmpty(basicHttpFetcherProxy)) {
        ProxySelectorRoutePlanner routePlanner = new  
ProxySelectorRoutePlanner(