You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by yuri1969 <gi...@git.apache.org> on 2017/09/22 18:23:51 UTC
[GitHub] nifi pull request #2170: NIFI-3803 - Allow use of up/down arrow keys...
GitHub user yuri1969 opened a pull request:
https://github.com/apache/nifi/pull/2170
NIFI-3803 - Allow use of up/down arrow keys...
...during selection in Add Processor dialog
* Added navigation logic to both Add Processor and Add CS dialogs.
* No extending to the SlickGrid library done.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yuri1969/nifi NIFI-3803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2170
----
commit 153b260900789f69e05424439602c7636d1a28b6
Author: yuri1969 <19...@gmail.com>
Date: 2017-09-18T20:58:59Z
NIFI-3803 - Allow use of up/down arrow keys...
...during selection in Add Processor dialog
* Added navigation logic to both Add Processor and Add CS dialogs.
* No extending to the SlickGrid library done.
----
---
[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Will review...
---
[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...
Posted by yuri1969 <gi...@git.apache.org>.
Github user yuri1969 commented on the issue:
https://github.com/apache/nifi/pull/2170
@mcgilman
- Thanks for pointing out this one. I forgot to include the _Add Reporting Task_ dialog completely...
- Now the `nfFilteredDialogCommon` should follow the SlickGrid's PageUp/Down navigation style. Please, check whether there are any differences.
---
[GitHub] nifi pull request #2170: NIFI-3803 - Allow use of up/down arrow keys...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2170
---
[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks @yuri1969! This has been merged to master.
---
[GitHub] nifi issue #2170: NIFI-3803 - Allow use of up/down arrow keys...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks for the PR @yuri1969! I had tried implementing this awhile back allowing the user to tab into the table and then navigate from there. I wasn't thrilled with the solution has it required the user to tab twice to get focus into the first visible row. I believe the double tab was required due to the 'focusSink' that `SlickGrid` adds to the DOM [1]. This functionality is already in your master. In conjunction with your PR, I like the capability much better. Now the user can navigate from the filter field and from the table if they get focus into the table via tab (albeit double tab) or clicking on a row.
Just a couple minor comments on the PR.
- I believe these `nfFilteredDialogCommon` needs to be included in nf-settings for the Add Reporting Task dialog.
- Also, I was wondering if it would be possible for pageDown/pageUp to select the first/last visible row after navigating. The behavior seems a little inconsistent currently. If the table has/had focus from clicking on a row, then the pageDown/pageUp behavior seems right. If it hasn't, the pageDown/pageUp just navigates the view but does not change the selected row. It would be nice if the selected row changed with the view regardless if the navigation is being triggered through `nfFilteredDialogCommon` or through the existing capabilities. Let me know if you need to me to explain what I'm seeing further.
[1] https://github.com/mleibman/SlickGrid/blob/bf4705a96c40fea088216034def4d0256a335e65/slick.grid.js#L237
---