You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/11/28 17:08:07 UTC

Re: Review Request 53690: Add namespaces/ipc documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 5:08 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-6557
    https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
-------

Add namespaces/ipc documentation.


Diffs (updated)
-----

  docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 

Diff: https://reviews.apache.org/r/53690/diff/


Testing
-------

Make check on Fedora 24.


Thanks,

James Peach


Re: Review Request 53690: Add namespaces/ipc documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/#review157369
-----------------------------------------------------------



Bad patch!

Reviews applied: [53690, 53689, 53688, 53628, 53627, 53626]

Failed command: ./support/apply-review.sh -n -r 53627

Error:
2016-11-30 04:50:22 URL:https://reviews.apache.org/r/53627/diff/raw/ [17209/17209] -> "53627.patch" [1]
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:1243
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/launch.hpp:55
error: src/slave/containerizer/mesos/launch.hpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/launch.cpp:120
error: src/slave/containerizer/mesos/launch.cpp: patch does not apply
error: patch failed: src/tests/containerizer/isolator_tests.cpp:57
error: src/tests/containerizer/isolator_tests.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/16270/console

- Mesos ReviewBot


On Nov. 29, 2016, 9:19 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53690/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 9:19 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6557
>     https://issues.apache.org/jira/browse/MESOS-6557
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add namespaces/ipc documentation.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 
> 
> Diff: https://reviews.apache.org/r/53690/diff/
> 
> 
> Testing
> -------
> 
> Make check on Fedora 24.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 53690: Add namespaces/ipc documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/#review157547
-----------------------------------------------------------



Patch looks great!

Reviews applied: [53688, 53689, 53690]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2016, 12:25 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53690/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 12:25 a.m.)
> 
> 
> Review request for mesos, Avinash Gautam and Jie Yu.
> 
> 
> Bugs: MESOS-6557
>     https://issues.apache.org/jira/browse/MESOS-6557
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add namespaces/ipc documentation.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 
> 
> Diff: https://reviews.apache.org/r/53690/diff/
> 
> 
> Testing
> -------
> 
> Make check on Fedora 24.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 53690: Add namespaces/ipc documentation.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/
-----------------------------------------------------------

(Updated Dec. 1, 2016, 12:25 a.m.)


Review request for mesos, Avinash Gautam and Jie Yu.


Bugs: MESOS-6557
    https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
-------

Add namespaces/ipc documentation.


Diffs (updated)
-----

  docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 

Diff: https://reviews.apache.org/r/53690/diff/


Testing
-------

Make check on Fedora 24.


Thanks,

James Peach


Re: Review Request 53690: Add namespaces/ipc documentation.

Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53690/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 9:19 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6557
    https://issues.apache.org/jira/browse/MESOS-6557


Repository: mesos


Description
-------

Add namespaces/ipc documentation.


Diffs (updated)
-----

  docs/mesos-containerizer.md 2bff35f6361f760a9001a249d2c01bbbc9e72932 

Diff: https://reviews.apache.org/r/53690/diff/


Testing
-------

Make check on Fedora 24.


Thanks,

James Peach