You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2017/07/28 15:37:41 UTC

jena git commit: Expand comment about the flow of HttpClient setup.

Repository: jena
Updated Branches:
  refs/heads/master d3fe87be0 -> 035ebba66


Expand comment about the flow of HttpClient setup.

Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/035ebba6
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/035ebba6
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/035ebba6

Branch: refs/heads/master
Commit: 035ebba6605fdb84dd4b194e0d89203df63a0f3c
Parents: d3fe87b
Author: Andy Seaborne <an...@apache.org>
Authored: Fri Jul 28 16:37:33 2017 +0100
Committer: Andy Seaborne <an...@apache.org>
Committed: Fri Jul 28 16:37:33 2017 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/jena/riot/RDFParserBuilder.java | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/035ebba6/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java b/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
index aaacd08..08c0d24 100644
--- a/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
+++ b/jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java
@@ -497,8 +497,12 @@ public class RDFParserBuilder {
             return httpClient;
         if ( httpHeaders.isEmpty() )
             // System default.
-            // For complete compatibility, we have to let null pass through.
-            return null; // HttpOp.getDefaultHttpClient();
+            // In this case, RDFParser will use the current-at-parse-time,
+            // settings of HttpOp, not frozen here. The HTTP step operation will use a
+            // general purpose accept header, WebContent.defaultRDFAcceptHeader, that
+            // gets any syntax of triples or quads. To freeze now to HttpOp settings, 
+            // call httpClient(HttpOp.getDefaultHttpClient). 
+            return null;
         List<Header> hdrs = new ArrayList<>();
         httpHeaders.forEach((k,v)->{
             Header header = new BasicHeader(k, v);