You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:07:07 UTC

[GitHub] [airflow] potiuk commented on pull request #13471: Remove thrift as a core dependency

potiuk commented on pull request #13471:
URL: https://github.com/apache/airflow/pull/13471#issuecomment-756105327


   > Except in this case we haven't actually removed the dep, at least not what is installed via the extras ;)
   
   True. I just prefer to be cautious and do it always. The way how PIP treats `install requires` when doing eager dependency update (so after it gets merged) might work in unexpected ways - depending if thrift is pre-installed before or not. 
   
   But yeah, probably in this case there are no scenarios where it would hurt us.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org