[jira] [Comment Edited] (AVRO-2143) ReflectData should determine inner class names in a different way.

["Miguel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361960#comment-16361960 ] 

Miguel edited comment on AVRO-2143 at 2/13/18 8:06 AM:
-------------------------------------------------------

It works perfectly as you suggested, well, just changing name to alias:
{code:java}
@AvroAlias(alias="Type", space="example com.company.avro.House")
{code}


was (Author: elmendavies):
It works perfectly as you suggested, well, just changing name to alias:


{code:java}
@AvroAlias(name="Type", space="example com.company.avro.House")
{code}




> ReflectData should determine inner class names in a different way.
> ------------------------------------------------------------------
>
>                 Key: AVRO-2143
>                 URL: https://issues.apache.org/jira/browse/AVRO-2143
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.7.7
>            Reporter: Miguel
>            Priority: Major
>
> I used ReflectData to generate schemas containing inner classes. These classes were named automatically by ReflectData with dollar ('$'), with, for example com.company.avro.House$Type. Nevertheless @AvroAlias does not support aliases containing '$' in names. In particulr, it fails in validateName in Schema core class. The failure is correct given that AVRO name specs does notinclude the '$' symbol. 
> I suppose that ReflectData should, for example, generate inner class names in a different way, such as replacing '$' by dots ('.'), or it should fail.
> And a detail: Although I cannot add aliases with '$', I can still encode and decode such objects and inner classes using that schema. 
> I think that it newer versions it is also happening.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)