You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Damjan Jovanovic (JIRA)" <ji...@apache.org> on 2010/08/27 14:25:53 UTC
[jira] Created: (SANSELAN-40) Improve ICO file support
Improve ICO file support
------------------------
Key: SANSELAN-40
URL: https://issues.apache.org/jira/browse/SANSELAN-40
Project: Commons Sanselan
Issue Type: Improvement
Environment: Sanselan, Java on any OS
Reporter: Damjan Jovanovic
Priority: Minor
I am submitting a patch that improves Sanselan's ICO format support. It adds:
1. Support for Windows Vista ICO files with embedded PNGs
2. Support for 256x256 icons (reported as 0x0)
3. Support for top-down and bottom-up bitmaps
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SANSELAN-40) Improve ICO file support
Posted by "Damjan Jovanovic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANSELAN-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Damjan Jovanovic updated SANSELAN-40:
-------------------------------------
Attachment: sanselan-ico.patch
New version of the patch. The patch now:
Uses only the BITMAPINFOHEADER to parse the icon (using the ICONDIRENTRY is wrong and the tests included prove it)
Adds support for writing ICO files
Adds support for reading 16 BPP ICO files
Adds support for compressed bitmaps
Adds support for the Windows Vista (and later) PNG ICO format
Verifies crucial fields in ICO files
Adds extensive tests
In fact the only feature now missing is support for the alpha channel in 32 BPP bitmaps, and that is something that needs to be added to BmpImageParser along with support for BITMAPV4HEADER/BITMAPV5HEADER anyway.
> Improve ICO file support
> ------------------------
>
> Key: SANSELAN-40
> URL: https://issues.apache.org/jira/browse/SANSELAN-40
> Project: Commons Sanselan
> Issue Type: Improvement
> Environment: Sanselan, Java on any OS
> Reporter: Damjan Jovanovic
> Priority: Minor
> Attachments: sanselan-better-ico.patch, sanselan-ico.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I am submitting a patch that improves Sanselan's ICO format support. It adds:
> 1. Support for Windows Vista ICO files with embedded PNGs
> 2. Support for 256x256 icons (reported as 0x0)
> 3. Support for top-down and bottom-up bitmaps
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SANSELAN-40) Improve ICO file support
Posted by "Damjan Jovanovic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANSELAN-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Damjan Jovanovic updated SANSELAN-40:
-------------------------------------
Attachment: sanselan-better-ico.patch
The patch against SVN HEAD.
> Improve ICO file support
> ------------------------
>
> Key: SANSELAN-40
> URL: https://issues.apache.org/jira/browse/SANSELAN-40
> Project: Commons Sanselan
> Issue Type: Improvement
> Environment: Sanselan, Java on any OS
> Reporter: Damjan Jovanovic
> Priority: Minor
> Attachments: sanselan-better-ico.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I am submitting a patch that improves Sanselan's ICO format support. It adds:
> 1. Support for Windows Vista ICO files with embedded PNGs
> 2. Support for 256x256 icons (reported as 0x0)
> 3. Support for top-down and bottom-up bitmaps
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SANSELAN-40) Improve ICO file support
Posted by "Charles Matthew Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SANSELAN-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Matthew Chen closed SANSELAN-40.
----------------------------------------
Resolution: Fixed
patch committed.
http://svn.apache.org/viewvc?view=revision&revision=995515
> Improve ICO file support
> ------------------------
>
> Key: SANSELAN-40
> URL: https://issues.apache.org/jira/browse/SANSELAN-40
> Project: Commons Sanselan
> Issue Type: Improvement
> Environment: Sanselan, Java on any OS
> Reporter: Damjan Jovanovic
> Priority: Minor
> Attachments: sanselan-better-ico.patch, sanselan-ico.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> I am submitting a patch that improves Sanselan's ICO format support. It adds:
> 1. Support for Windows Vista ICO files with embedded PNGs
> 2. Support for 256x256 icons (reported as 0x0)
> 3. Support for top-down and bottom-up bitmaps
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.