[GitHub] [hbase] virajjasani commented on a change in pull request #3640: HBASE-25588 Excessive logging of "hbase.zookeeper.useMulti is deprecated. Default to true always."

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #3640:
URL: https://github.com/apache/hbase/pull/3640#discussion_r697970664



##########
File path: hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -1760,6 +1760,10 @@ private static Op toZooKeeperOp(ZKWatcher zkw, ZKUtilOp op) throws UnsupportedOp
     }
   }
 
+  // Static boolean for warning about useMulti because we only want one warning per process
+  // instance.
+  private static boolean useMultiWarn = true;

Review comment:
       I think simple comment is fine, because even if more than one thread enters the if block before reading the correctly reset value of boolean, we will still have quite limited occurrence of this logging, which is still much better than prior to this patch scenario.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org