[jira] [Commented] (HDDS-14740) Implement ScmListCodec without reflection.

["Tsz-wo Sze (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDDS-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18065912#comment-18065912 ] 

Tsz-wo Sze commented on HDDS-14740:
-----------------------------------

{quote}
1. find out all the proto classes T which are passing as parameter List<T> ,
2. change ScmListCodec to support generic type, and
3. add a ScmListCodec for each proto class.
{quote}
Sorry that the idea above does not work well for ScmListCodec.

Could you see if [this idea|https://issues.apache.org/jira/secure/attachment/13081236/9919_review.patch] would work?

> Implement ScmListCodec without reflection.
> ------------------------------------------
>
>                 Key: HDDS-14740
>                 URL: https://issues.apache.org/jira/browse/HDDS-14740
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: SCM HA
>            Reporter: Tsz-wo Sze
>            Assignee: Chen-Jheng Sing
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 9919_review.patch
>
>
> Similar to HDDS-14647, we should
> # find out all the proto classes T which are passing as parameter List<T> ,
> # change ScmListCodec to support generic type, and
> # add a ScmListCodec for each proto class.
> If there are many proto classes required, we may consider adding the codec dynamically, i.e. use reflection or other method to add the codec when it is required the first time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org