You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/01 06:33:33 UTC

[GitHub] [flink] zhule0601 opened a new pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

zhule0601 opened a new pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590
 
 
   ## What is the purpose of the change
   
   This pull request translates the scala_shell_hive.zh.md document into Chinese.
   
   ## Brief change log
   
   - Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese 
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no 
     - The runtime per-record code paths (performance sensitive):  no 
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no 
     - The S3 file system connector: no 
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#issuecomment-607063379
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8d4774382b57353f1de2f37c23144f4f2321b443 (Wed Apr 01 06:35:36 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#issuecomment-607068581
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157422842",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8d4774382b57353f1de2f37c23144f4f2321b443 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/157422842) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#issuecomment-607068581
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157422842",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8d4774382b57353f1de2f37c23144f4f2321b443 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157422842) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#discussion_r410333729
 
 

 ##########
 File path: docs/dev/table/hive/scala_shell_hive.zh.md
 ##########
 @@ -22,18 +22,18 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-NOTE: since blink planner is not well supported in Scala Shell at the moment, it's **NOT** recommended to use Hive connector in Scala Shell.
+注意：目前 blink 计划器还不能很好的支持 Scala Shell，因此 **不** 建议在 Scala Shell 中使用 Hive 连接器。
 
-[Flink Scala Shell]({{ site.baseurl }}/ops/scala_shell.html) is a convenient quick way to try flink. 
-You can use hive in scala shell as well instead of specifying hive dependencies in pom file, packaging your program and submitting it via flink run command.
-In order to use hive connector in scala shell, you need to put the following [hive connector dependencies]({{ site.baseurl }}/dev/table/hive/#depedencies) under lib folder of flink dist .
+[Flink Scala Shell]({{ site.baseurl }}/zh/ops/scala_shell.html) 是快速上手 Flink 的好方法。
+你需要在 pom 中引进 Hive 的依赖，打包并通过 Flink run 来提交 Hive 作业，而在 Scala Shell 中使用 Hive 连接器可以代替这种提交方式。
+想要在 Scala Shell 中使用 Hive 连接器，你需要把 [Hive 连接器依赖项]({{ site.baseurl }}/zh/dev/table/hive/#depedencies) 放在 Flink 源码的 lib 文件夹下
 
 Review comment:
   这里不是放到 “Flink 源码” 的 lib 文件夹下，而是最后打出来的 dist 包中的 lib 目录下

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#issuecomment-607068581
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     }, {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/157422842",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8d4774382b57353f1de2f37c23144f4f2321b443 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/157422842) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6909) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#discussion_r410332889
 
 

 ##########
 File path: docs/dev/table/hive/scala_shell_hive.zh.md
 ##########
 @@ -22,18 +22,18 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-NOTE: since blink planner is not well supported in Scala Shell at the moment, it's **NOT** recommended to use Hive connector in Scala Shell.
+注意：目前 blink 计划器还不能很好的支持 Scala Shell，因此 **不** 建议在 Scala Shell 中使用 Hive 连接器。
 
-[Flink Scala Shell]({{ site.baseurl }}/ops/scala_shell.html) is a convenient quick way to try flink. 
-You can use hive in scala shell as well instead of specifying hive dependencies in pom file, packaging your program and submitting it via flink run command.
-In order to use hive connector in scala shell, you need to put the following [hive connector dependencies]({{ site.baseurl }}/dev/table/hive/#depedencies) under lib folder of flink dist .
+[Flink Scala Shell]({{ site.baseurl }}/zh/ops/scala_shell.html) 是快速上手 Flink 的好方法。
+你需要在 pom 中引进 Hive 的依赖，打包并通过 Flink run 来提交 Hive 作业，而在 Scala Shell 中使用 Hive 连接器可以代替这种提交方式。
+想要在 Scala Shell 中使用 Hive 连接器，你需要把 [Hive 连接器依赖项]({{ site.baseurl }}/zh/dev/table/hive/#depedencies) 放在 Flink 源码的 lib 文件夹下
 
 Review comment:
   比较奇怪的是原文中 “Scala Shell” 的拼写并不统一，有 “Scala Shell” 有 “scala shell”。你觉得哪个更好呢？另外你觉得原文中的描述是否需要进行统一呢？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#issuecomment-607068581
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8d4774382b57353f1de2f37c23144f4f2321b443",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8d4774382b57353f1de2f37c23144f4f2321b443 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#discussion_r410328532
 
 

 ##########
 File path: docs/dev/table/hive/scala_shell_hive.zh.md
 ##########
 @@ -22,18 +22,18 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-NOTE: since blink planner is not well supported in Scala Shell at the moment, it's **NOT** recommended to use Hive connector in Scala Shell.
+注意：目前 blink 计划器还不能很好的支持 Scala Shell，因此 **不** 建议在 Scala Shell 中使用 Hive 连接器。
 
 Review comment:
   planner 翻译成计划器合理吗？

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese

Posted by GitBox <gi...@apache.org>.
klion26 commented on a change in pull request #11590: [FLINK-16102][docs-zh] Translate docs/dev/table/hive/scala_shell_hive.zh.md into Chinese
URL: https://github.com/apache/flink/pull/11590#discussion_r410331894
 
 

 ##########
 File path: docs/dev/table/hive/scala_shell_hive.zh.md
 ##########
 @@ -22,18 +22,18 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-NOTE: since blink planner is not well supported in Scala Shell at the moment, it's **NOT** recommended to use Hive connector in Scala Shell.
+注意：目前 blink 计划器还不能很好的支持 Scala Shell，因此 **不** 建议在 Scala Shell 中使用 Hive 连接器。
 
-[Flink Scala Shell]({{ site.baseurl }}/ops/scala_shell.html) is a convenient quick way to try flink. 
-You can use hive in scala shell as well instead of specifying hive dependencies in pom file, packaging your program and submitting it via flink run command.
-In order to use hive connector in scala shell, you need to put the following [hive connector dependencies]({{ site.baseurl }}/dev/table/hive/#depedencies) under lib folder of flink dist .
+[Flink Scala Shell]({{ site.baseurl }}/zh/ops/scala_shell.html) 是快速上手 Flink 的好方法。
+你需要在 pom 中引进 Hive 的依赖，打包并通过 Flink run 来提交 Hive 作业，而在 Scala Shell 中使用 Hive 连接器可以代替这种提交方式。
 
 Review comment:
   这句话读起来怪怪的，是不是可以考虑换成类似“你可以在 Scala Shell 中直接使用 Hive 连接器，而不需要在 pom 中添加 Hive 相关依赖，并提交作业” 或者其他类似的

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services