You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/26 03:35:33 UTC

[GitHub] [flink] docete commented on a change in pull request #10562: [FLINK-15231][table-planner-blink] Do not support TIMESTAMP/DECIMAL t…

docete commented on a change in pull request #10562: [FLINK-15231][table-planner-blink] Do not support TIMESTAMP/DECIMAL t…
URL: https://github.com/apache/flink/pull/10562#discussion_r361360066
 
 

 ##########
 File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/heap/AbstractHeapVector.java
 ##########
 @@ -109,18 +107,7 @@ public static AbstractHeapVector createHeapColumn(LogicalType fieldType, int max
 			case TIME_WITHOUT_TIME_ZONE:
 				return new HeapIntVector(maxRows);
 			case BIGINT:
-			case TIMESTAMP_WITHOUT_TIME_ZONE:
 
 Review comment:
   Uses should use `allocateHeapVectors` or `createHeapColumn` to create HeapVectors. See the java doc of constructor of `HeapIntVector`. Uses should not call `new HeapIntVector(len)` except for testing purposes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services