You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/15 13:05:45 UTC

[GitHub] [flink] AHeise commented on pull request #17692: [FLINK-24489][CEP] The size of entryCache & eventsBufferCache in the SharedBuffer should be defined with a threshold to limit the number of the elements in the cache

AHeise commented on pull request #17692:
URL: https://github.com/apache/flink/pull/17692#issuecomment-968890973


   The situation is a bit odd. I think we shouldn't have a cache on top of rocks DB at all. We could think about having a cache in rocks DB itself.
   
   Nevertheless, the cache is there and causes trouble for you. I understood now that your changes are not impacting correctness but only performance, so I think your contribution certainly is welcome.
   
   To reiterate from my first rough review: Could you please add a (unit) test and make the configuration descriptions easier to understand for folks that have not read the CEP code?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org