You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/22 09:08:50 UTC

[GitHub] [pulsar] Jason918 opened a new pull request #12916: [metadata] Optimize put and get methods in AbstractMetadataStore

Jason918 opened a new pull request #12916:
URL: https://github.com/apache/pulsar/pull/12916


   ### Motivation
   
   For the convenience to implement other metadata store, I am proposing two small optimizations to AbstractMetadataStore.
   1. The implementation of `put` is the same in `LocalMemoryMetadataStore` and `ZKMetadataStore`, can be moved to AbstractMetadataStore. 
   2. Add abstract method `storeGet` in AbstractMetadataStore, so that all subclass only need to implement "storeXXX" version methods. And we can add common code in `AbstractMetadataStore#get` like the path parameter check.
   
   ### Modifications
   
   See above.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
     
   - [x] `no-need-doc` 
   
   Code optimize. No user behavior changed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #12916: [metadata] Optimize put and get methods in AbstractMetadataStore

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12916:
URL: https://github.com/apache/pulsar/pull/12916


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org