You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/24 07:45:50 UTC
[GitHub] [camel] sekikn opened a new pull request, #8768: docs - Simplify steps for building thrift compiler
sekikn opened a new pull request, #8768:
URL: https://github.com/apache/camel/pull/8768
In components/camel-thrift/README.md, the steps for building thrift compiler is described as follows.
```
sudo ./bootstrap.sh
export CXXFLAGS='-Os -ffunction-sections -Wl,--gc-sections -fno-asynchronous-unwind-tables -Wl,--strip-all'
sudo ./configure --without-c_glib --without-java --without-python --without-ruby --without-nodejs --disable-libs --disable-tests --disable-tutorial --disable-shared --enable-static
sudo make check
sudo make install
```
But these commands are unnecessarily verbose.
* `sudo`s are not required except for the last one
* `CXXFLAGS` doesn't seem to be necessary, at least for recent Thrift releases
* The `--disable-libs` option supercedes other `--without-*` options. Other `--disable-*` options also seem to be unnecessary
* `make check` is not mandatory, only `make` is enough for building
You can make sure these, for example:
```
$ docker run -it ubuntu:22.04 bash
root@707c001cfb00:/# apt-get update -qq
root@707c001cfb00:/# apt-get install -qq bison build-essential cmake curl debhelper flex g++ pkg-config qtbase5-dev sudo
root@707c001cfb00:/# useradd -m -s /bin/bash user
root@707c001cfb00:/# usermod user -aG sudo
root@707c001cfb00:/# passwd user
root@707c001cfb00:/# su - user
user@707c001cfb00:~$ curl -sLO https://github.com/apache/thrift/archive/refs/tags/v0.17.0.tar.gz
user@707c001cfb00:~$ tar xf v0.17.0.tar.gz
user@707c001cfb00:~$ cd thrift-0.17.0
user@707c001cfb00:~/thrift-0.17.0$ ./bootstrap.sh
user@707c001cfb00:~/thrift-0.17.0$ ./configure --disable-libs
user@707c001cfb00:~/thrift-0.17.0$ make
user@707c001cfb00:~/thrift-0.17.0$ sudo make install
user@707c001cfb00:~/thrift-0.17.0$ thrift -version
Thrift version 0.17.0
```
<!-- Uncomment and fill this section if your PR is not trivial
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8768: docs - Simplify steps for building thrift compiler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8768:
URL: https://github.com/apache/camel/pull/8768#issuecomment-1326069399
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8768: docs - Simplify steps for building thrift compiler
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8768:
URL: https://github.com/apache/camel/pull/8768#issuecomment-1326486535
Thanks for helping with this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #8768: docs - Simplify steps for building thrift compiler
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8768:
URL: https://github.com/apache/camel/pull/8768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8768: docs - Simplify steps for building thrift compiler
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8768:
URL: https://github.com/apache/camel/pull/8768#issuecomment-1326112583
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org