You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/03/04 14:10:19 UTC

[commons-jexl] branch master updated: Use StringBuilder instead of StringBuffer for internal processing

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-jexl.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e3ab611 Use StringBuilder instead of StringBuffer for internal processing
     new 7046e765 Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-jexl.git
4e3ab611 is described below

commit 4e3ab6119ba18e8ef30e5b5ad7fca8b15e639437
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Mar 4 09:09:44 2023 -0500

    Use StringBuilder instead of StringBuffer for internal processing
---
 .../apache/commons/jexl3/internal/TemplateEngine.java  |  2 +-
 src/test/java/org/apache/commons/jexl3/ScriptTest.java | 18 ++++++++++--------
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
index ebed2e41..6dd7793a 100644
--- a/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
+++ b/src/main/java/org/apache/commons/jexl3/internal/TemplateEngine.java
@@ -1104,7 +1104,7 @@ public final class TemplateEngine extends JxltEngine {
             private CharSequence next = doNext();
 
             private CharSequence doNext() {
-                final StringBuffer strb = new StringBuffer(64); // CSOFF: MagicNumber
+                final StringBuilder strb = new StringBuilder(64); // CSOFF: MagicNumber
                 int c;
                 boolean eol = false;
                 try {
diff --git a/src/test/java/org/apache/commons/jexl3/ScriptTest.java b/src/test/java/org/apache/commons/jexl3/ScriptTest.java
index 1f16d870..15b4a343 100644
--- a/src/test/java/org/apache/commons/jexl3/ScriptTest.java
+++ b/src/test/java/org/apache/commons/jexl3/ScriptTest.java
@@ -16,16 +16,11 @@
  */
 package org.apache.commons.jexl3;
 
-import com.sun.net.httpserver.HttpExchange;
-import com.sun.net.httpserver.HttpHandler;
-import com.sun.net.httpserver.HttpServer;
-import org.junit.Assert;
-import org.junit.Test;
-
 import java.io.BufferedReader;
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.InputStreamReader;
 import java.io.OutputStream;
 import java.net.HttpURLConnection;
 import java.net.InetSocketAddress;
@@ -34,6 +29,13 @@ import java.util.concurrent.Executors;
 import java.util.concurrent.ThreadPoolExecutor;
 import java.util.function.Function;
 
+import org.junit.Assert;
+import org.junit.Test;
+
+import com.sun.net.httpserver.HttpExchange;
+import com.sun.net.httpserver.HttpHandler;
+import com.sun.net.httpserver.HttpServer;
+
 /**
  * Tests for JexlScript
  * @since 1.1
@@ -173,9 +175,9 @@ public class ScriptTest extends JexlTestCase {
         int responseCode = con.getResponseCode();
         InputStream inputStream = null;
         inputStream =  con.getInputStream();
-        StringBuffer response = new java.lang.StringBuffer();
+        StringBuilder response = new StringBuilder();
         if (inputStream != null) {
-            try (BufferedReader in = new java.io.BufferedReader(new java.io.InputStreamReader(inputStream))) {
+            try (BufferedReader in = new BufferedReader(new InputStreamReader(inputStream))) {
                 String inputLine = "";
                 while ((inputLine = in.readLine()) != null) {
                     response.append(inputLine);