[jira] [Commented] (ZOOKEEPER-1202) Prevent certain state transitions in Java client on close(); improve exception handling and enhance client testability

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113114#comment-13113114 ] 

Hadoop QA commented on ZOOKEEPER-1202:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12496216/ZOOKEEPER-1202.patch
  against trunk revision 1173949.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/586//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/586//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/586//console

This message is automatically generated.

> Prevent certain state transitions in Java client on close(); improve exception handling and enhance client testability
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1202
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1202
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.4.0
>            Reporter: Matthias Spycher
>            Assignee: Matthias Spycher
>         Attachments: ZOOKEEPER-1202.patch
>
>
> ZooKeeper.close() doesn't force the client into a CLOSED state. While the closing flag ensures that the client will close, its state may end up in CLOSED, CONNECTING or CONNECTED.
> I developed a patch and in the process cleaned up a few other things primarily to enable testing of state transitions.
> - ClientCnxnState is new and enforces certain state transitions
> - ZooKeeper.isExpired() is new
> - ClientCnxn no longer refers to ZooKeeper, WatchManager is externalized, and ClientWatchManager includes 3 new methods
> - The SendThread terminates the EventThread on a call to close() via the event-of-death
> - Polymorphism is used to handle internal exceptions (SendIOExceptions)
> - The patch incorporates ZOOKEEPER-126.patch and prevents close() from blocking

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira