[GitHub] [flink] wuchong commented on a change in pull request #13763: [FLINK-19779][avro] Remove the record_ field name prefix for Confluen…

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #13763:
URL: https://github.com/apache/flink/pull/13763#discussion_r512632436



##########
File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java
##########
@@ -297,17 +299,22 @@ private static DataType convertToDataType(Schema schema) {
 	 * @return Avro's {@link Schema} matching this logical type.
 	 */
 	public static Schema convertToSchema(LogicalType logicalType) {
-		return convertToSchema(logicalType, "record");
+		return convertToSchema(logicalType, "record", true);
 	}
 
 	/**
 	 * Converts Flink SQL {@link LogicalType} (can be nested) into an Avro schema.
 	 *
 	 * @param logicalType logical type
 	 * @param rowName     the record name
+	 * @param top         whether it is parsing the root record,
+	 *                    if it is, the logical type nullability would be ignored
 	 * @return Avro's {@link Schema} matching this logical type.
 	 */
-	public static Schema convertToSchema(LogicalType logicalType, String rowName) {
+	public static Schema convertToSchema(
+			LogicalType logicalType,
+			String rowName,
+			boolean top) {

Review comment:
       I have the same feeling with @dawidwys . 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org