You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2011/01/04 17:40:53 UTC
svn commit: r1055095 -
/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
Author: ivaynberg
Date: Tue Jan 4 16:40:53 2011
New Revision: 1055095
URL: http://svn.apache.org/viewvc?rev=1055095&view=rev
Log:
Issue: WICKET-3302
Modified:
wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
Modified: wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java?rev=1055095&r1=1055094&r2=1055095&view=diff
==============================================================================
--- wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java (original)
+++ wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/Component.java Tue Jan 4 16:40:53 2011
@@ -3293,39 +3293,49 @@ public abstract class Component implemen
*/
public String toString(final boolean detailed)
{
- if (detailed)
+ try
{
- final Page page = findPage();
- if (page == null)
+ if (detailed)
{
- return new StringBuffer("[Component id = ").append(getId())
- .append(", page = <No Page>, path = ")
- .append(getPath())
- .append(".")
- .append(Classes.simpleName(getClass()))
- .append("]")
- .toString();
+ final Page page = findPage();
+ if (page == null)
+ {
+ return new StringBuffer("[Component id = ").append(getId())
+ .append(", page = <No Page>, path = ")
+ .append(getPath())
+ .append(".")
+ .append(Classes.simpleName(getClass()))
+ .append("]")
+ .toString();
+ }
+ else
+ {
+ return new StringBuffer("[Component id = ").append(getId())
+ .append(", page = ")
+ .append(getPage().getClass().getName())
+ .append(", path = ")
+ .append(getPath())
+ .append(".")
+ .append(Classes.simpleName(getClass()))
+ .append(", isVisible = ")
+ .append((determineVisibility()))
+ .append(", isVersioned = ")
+ .append(isVersioned())
+ .append("]")
+ .toString();
+ }
}
else
{
- return new StringBuffer("[Component id = ").append(getId())
- .append(", page = ")
- .append(getPage().getClass().getName())
- .append(", path = ")
- .append(getPath())
- .append(".")
- .append(Classes.simpleName(getClass()))
- .append(", isVisible = ")
- .append((determineVisibility()))
- .append(", isVersioned = ")
- .append(isVersioned())
- .append("]")
- .toString();
+ return "[Component id = " + getId() + "]";
}
}
- else
+ catch (Exception e)
{
- return "[Component id = " + getId() + "]";
+ log.warn("Error while building toString()", e);
+ return String.format(
+ "[Component id = %s <attributes are not available because exception %s was thrown during toString()>]",
+ getId(), e.getClass().getName());
}
}