[jira] [Comment Edited] (OAK-10719) oak-lucene uses Lucene version that can throw a StackOverflowException

["Julian Reschke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-10719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830914#comment-17830914 ] 

Julian Reschke edited comment on OAK-10719 at 3/28/24 11:06 AM:
----------------------------------------------------------------

Question: if we stick with the "copy the source and fix it approach" - maybe we can get away with copying the source of just the affected class? (to be tested)


was (Author: reschke):
Question: if we stick with the "copy the source and fix it approach" - maybe we cab get away with copying the source of just the affected class? (to be tested)

> oak-lucene uses Lucene version that can throw a StackOverflowException
> ----------------------------------------------------------------------
>
>                 Key: OAK-10719
>                 URL: https://issues.apache.org/jira/browse/OAK-10719
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>
> See <https://github.com/apache/lucene/issues/11537>.
> Analysis so far:
> - oak-lucene uses lucene-core (4.7.2) (see OAK-10716); that version has reached EOL a long time ago
> - the lucene version can in some cases throw a StackOverflowException, see OAK-10713
> - oak-lucene *embeds* and *exports* lucene-core
> - update to version >= 4.8 non-trivial due to backwards compat breakage
> Work in <https://github.com/reschke/jackrabbit-oak-lucene/tree/lucene-poc>:
> - inlined lucene-core as of git tag "releases/lucene-solr/4.7.2" into oak-lucene
> - fixed two JDK11 compile issues (potentially uninitialized vars in finally block) 
> - backported fix from https://github.com/apache/lucene/issues/11537
> - enable test added in OAK-10713
> - ran Oak integration tests
> Open questions:
> - Lucene 4.7.2 builds with ant/ivy - does it make sense to try to replicate that
> - should we ask Lucene team for a public release (might be hard sell)
> - alternatively, as tried here, inline source code into oak-lucene (maybe add explainers to all source files)
> - do we need to adopt the lucene test suite as well?
> - lucene-core dependencies in other Oak modules to be checked (seems mostly for tests, or for run modules)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)