[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

[GitBox <gi...@apache.org>]

cklein05 commented on pull request #428:
URL: https://github.com/apache/tomcat/pull/428#issuecomment-916111826


   Rémy,
   
   I agree with you that, for MemoryRealm and UserDatabaseRealm, this feature is not that much useful. However, for the sake of _completeness_ (aka all realms should behave the same, in a way) these do support additional user attributes as well. Nevertheless, the feature is primarily intended to provide a _user friendly_ user name easily. The UserDatabase supports the `fullname` attribute, so, this is still a simple way to provide this to the application.
   
   With DataSourceRealm it's nearly as much as useful than with JNDIRealm, since one can always add many _interesting_ columns to the `tomcat_users` database table. In my company, we have several production applications that relay on DataSourceRealm connected to a PostgreSQL user database.
   
   I agreed with Mark and Michael to remove the whole _defensive copy_ stuff. However, that's not yet pushed back onto my GitHub repository. Shall I do so?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org