You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "MartinEmrich (via GitHub)" <gi...@apache.org> on 2023/10/31 11:12:39 UTC
[PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
MartinEmrich opened a new pull request, #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355
https://github.com/apache/cloudstack/issues/8157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355#issuecomment-1787182089
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "MartinEmrich (via GitHub)" <gi...@apache.org>.
MartinEmrich commented on code in PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355#discussion_r1377540549
##########
source/adminguide/templates.rst:
##########
@@ -413,6 +413,11 @@ When templates are deleted, the VMs instantiated from them will continue
to run. However, new VMs cannot be created based on the deleted
template.
+Cloudstack refuses to delete a template when VMs based on the template
+exist. If this is the case, the parameter "forced" has to be
+set to "true" to delete the template anyways. These VMs can no longer be
+reinstalled from that template, but will be unaffected otherwise.
+
Review Comment:
Yes, I tried to rephrase it a little. As long as it is factually correct, I like it that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355#discussion_r1377497547
##########
source/adminguide/templates.rst:
##########
@@ -413,6 +413,11 @@ When templates are deleted, the VMs instantiated from them will continue
to run. However, new VMs cannot be created based on the deleted
template.
+Cloudstack refuses to delete a template when VMs based on the template
+exist. If this is the case, the parameter "forced" has to be
+set to "true" to delete the template anyways. These VMs can no longer be
+reinstalled from that template, but will be unaffected otherwise.
+
Review Comment:
looks good, but I think the text should be integrated with the previous paragraph(s).
##########
source/adminguide/templates.rst:
##########
@@ -413,6 +413,11 @@ When templates are deleted, the VMs instantiated from them will continue
to run. However, new VMs cannot be created based on the deleted
template.
+Cloudstack refuses to delete a template when VMs based on the template
+exist. If this is the case, the parameter "forced" has to be
+set to "true" to delete the template anyways. These VMs can no longer be
+reinstalled from that template, but will be unaffected otherwise.
+
Review Comment:
start of the first paragraph
```
Templates may be deleted. However when the templates are used the default behaviour is to refuse deletion. In general, when a template spans multiple
Zones, only the copy that is selected ....
```
and hence
```suggestion
As said Cloudstack refuses to delete a template when VMs based on the template
exist. If this is the case, the parameter "forced" has to be
set to "true" to delete the template anyways. These VMs can no longer be
reinstalled from that template, but will be unaffected otherwise.
```
What do you think @MartinEmrich ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355#issuecomment-1787183228
@DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarify consequences of deleting templates in use by VMs. [cloudstack-documentation]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #355:
URL: https://github.com/apache/cloudstack-documentation/pull/355#issuecomment-1787184643
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/355. (QA-JID 164)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org