You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/01 18:36:52 UTC
[kudu-CR](branch-1.17.x) jwt: add control points for test binaries
Hello Attila Bukor, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19970
to review the following change.
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Reviewed-on: http://gerrit.cloudera.org:8080/18476
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 3d56a26b962d83f3f2789b2f2c7c2967322e98e9)
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 94 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/19970/1
--
To view, visit http://gerrit.cloudera.org:8080/19970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 19970
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) jwt: add control points for test binaries
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19970 )
Change subject: jwt: add control points for test binaries
......................................................................
jwt: add control points for test binaries
This hooks the configurations of the MiniOidc into the Java test binary,
allowing test code to add statically-defined JWKS associated with
specific account IDs, to be fetched via OIDC Discovery Endpoint.
Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Reviewed-on: http://gerrit.cloudera.org:8080/18476
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
(cherry picked from commit 3d56a26b962d83f3f2789b2f2c7c2967322e98e9)
Reviewed-on: http://gerrit.cloudera.org:8080/19970
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
5 files changed, 94 insertions(+), 8 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yingchun Lai: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 19970
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) jwt: add control points for test binaries
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19970 )
Change subject: jwt: add control points for test binaries
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I489a67e93610467c5a2caabcf3e5603cbb49d118
Gerrit-Change-Number: 19970
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 02 Jun 2023 06:35:42 +0000
Gerrit-HasComments: No