You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/11/17 11:19:55 UTC
[GitHub] incubator-brooklyn pull request: Remove catalog item parameters in...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1036
Remove catalog item parameters in line with type registry changes
First commit somehow got excluded from the original PR.
Second commit removes the catalog item getParameters API as discussed in type registry PRs. It was merged 8 days ago, so no point in going through a deprecation cycle.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn remove-catalog-params
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1036.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1036
----
commit 8b1d180d7d50b19c222d2bad58ee060f4c88c3aa
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-11-16T13:48:10Z
Don't display unpinned parameters
Parameters are now sorted on the server with priority == 1 if visible and null (received as undefined) otherwise.
commit 7c7b3543c65074adb949c9cd9a179505c5ccd0da
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-11-17T09:50:39Z
Remove catalog item parameters in line with type registry changes
The parameters are still populated in the spec, it's just the catalog item that doesn't have the API to get the parameters. Also fixes another shortcoming where parameters in catalog items were eagerly evaluated, not updating if dependant catalog items changed.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove catalog item parameters in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1036
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Remove catalog item parameters in...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1036#issuecomment-157386342
looks good; i'll sort out conflicts with #1017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---