You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/08/07 11:46:44 UTC
Re: Review Request 37189: Added std::hash template specializations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 11:46 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Summary (updated)
-----------------
Added std::hash template specializations.
Repository: mesos
Description (updated)
-------
Added std::hash template specializations.
Diffs
-----
include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94523
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 7, 2015, 10:28 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 10:28 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
> src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
> src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
> src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94533
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 7, 2015, 11:52 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 11:52 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
> src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
> src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
> src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94539
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Aug. 7, 2015, 1:52 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 1:52 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
> src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
> src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
> src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Aug. 11, 2015, 5:39 a.m., Michael Park wrote:
> > Looks good overall! Same question as [r37188](https://reviews.apache.org/r/37188/): why did you decide to leave the `hash_value` functions and call it from `std::hash` specializations rather than moving the logic?
I assumed that there may be other functionality that depends on the `hash_value` functions. After moving the logic to `std::hash`, the only dependencies were in stout/cache.hpp and stout/multihashmap.hpp. Both also relied on boost, which I changed to std includes. See r37187 for the added changes.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94859
-----------------------------------------------------------
On Aug. 11, 2015, 11:58 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 11:58 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94859
-----------------------------------------------------------
Looks good overall! Same question as [r37188](https://reviews.apache.org/r/37188/): why did you decide to leave the `hash_value` functions and call it from `std::hash` specializations rather than moving the logic?
include/mesos/type_utils.hpp (line 493)
<https://reviews.apache.org/r/37189/#comment149514>
`s/template<>/template <>/`
include/mesos/type_utils.hpp (line 503)
<https://reviews.apache.org/r/37189/#comment149515>
`s/template<>/template <>/`
include/mesos/type_utils.hpp (line 513)
<https://reviews.apache.org/r/37189/#comment149516>
`s/template<>/template <>/`
include/mesos/type_utils.hpp (line 523)
<https://reviews.apache.org/r/37189/#comment149517>
`s/template<>/template <>/`
include/mesos/type_utils.hpp (line 533)
<https://reviews.apache.org/r/37189/#comment149518>
`s/template<>/template <>/`
src/linux/cgroups.hpp (line 655)
<https://reviews.apache.org/r/37189/#comment149519>
`s/template<>/template <>/`
src/messages/log.hpp (line 56)
<https://reviews.apache.org/r/37189/#comment149520>
`{` on the next line.
src/module/manager.hpp (lines 160 - 161)
<https://reviews.apache.org/r/37189/#comment149521>
This now fits in one line.
src/tests/containerizer.hpp (line 52)
<https://reviews.apache.org/r/37189/#comment149522>
`s/template<>/template <>/`
src/tests/module.hpp (line 87)
<https://reviews.apache.org/r/37189/#comment149524>
`s/template<>/template <>/`
- Michael Park
On Aug. 10, 2015, 12:26 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:26 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
> src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94748
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 10, 2015, 12:26 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 12:26 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
> src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96333
-----------------------------------------------------------
This is slightly out of date now with the modularized authorizer. Could you rebase this please?
- Michael Park
On Aug. 11, 2015, 12:30 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 12:30 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Aug. 26, 2015, 5:10 p.m., Michael Park wrote:
> > src/tests/containerizer.hpp, lines 50-65
> > <https://reviews.apache.org/r/37189/diff/7/?file=1051138#file1051138line50>
> >
> > Could this not be located at the bottom of this file? If not, it would be preferred to leave the forward declaration at the top and define it at the bottom.
Moved it to `type_utils.hpp`, where all protobuf related hashes are.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96532
-----------------------------------------------------------
On Aug. 26, 2015, 5:45 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 5:45 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96532
-----------------------------------------------------------
src/tests/containerizer.hpp (lines 50 - 65)
<https://reviews.apache.org/r/37189/#comment151976>
Could this not be located at the bottom of this file? If not, it would be preferred to leave the forward declaration at the top and define it at the bottom.
- Michael Park
On Aug. 25, 2015, 1:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 1:16 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96355
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Aug. 25, 2015, 1:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 1:16 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96636
-----------------------------------------------------------
Sorry I keep finding more stuff, but the same changes will need to be made to `include/mesos/v1/mesos.hpp`. The changes were introduced after you started working on this. Thanks!
include/mesos/type_utils.hpp (line 395)
<https://reviews.apache.org/r/37189/#comment152229>
We keep 2 newlines between top-level definitions, here and below.
- Michael Park
On Aug. 26, 2015, 3:45 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 3:45 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96673
-----------------------------------------------------------
It looks like there's an unused instance of `hash_value` in `src/linux/routing/filter/ip.hpp`. Can we get rid of that one?
- Michael Park
On Aug. 27, 2015, 11:42 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 11:42 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96702
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 27, 2015, 4:24 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 4:24 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [3/3] Mesos: Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96739
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Aug. 27, 2015, 6:02 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 6:02 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [3/3] Mesos: Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96732
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 27, 2015, 6:02 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 6:02 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> [3/3] Mesos: Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 8:02 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Add std::hash<PortRange> again: it's used if compiled with `--with-network-isolator`
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
[3/3] Mesos: Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 6:24 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Remove unused std::hash<PortRange>
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description (updated)
-------
[3/3] Mesos: Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96689
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 27, 2015, 3:15 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 3:15 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 5:15 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Add result_type, argument_type for std::hash specializations.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/linux/routing/filter/ip.hpp 0a778618bc68db9ab4ad59f887fcdd0352561a5e
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96675
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 27, 2015, 11:42 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 11:42 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 27, 2015, 1:42 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Added new lines & converted hash_value to std::hash in v1/mesos.hpp.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
include/mesos/v1/mesos.hpp d06875e0f116842382c18d05ad466ccb97dca24a
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96544
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 26, 2015, 3:45 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 3:45 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96572
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Aug. 26, 2015, 3:45 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 3:45 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 5:45 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Fix open issues.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 92a0b4674d6058e27044f990c07dee922567fda6
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96531
-----------------------------------------------------------
include/mesos/type_utils.hpp (lines 474 - 492)
<https://reviews.apache.org/r/37189/#comment151974>
Originally `CommandInfo_URI` was above `ContainerID`, and it looks like alphabetically it belongs above `ContainerID` as well.
Why was this relocated?
- Michael Park
On Aug. 25, 2015, 1:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 1:16 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review96336
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 25, 2015, 1:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2015, 1:16 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 3:16 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Rebase master
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 862b71fa9d1e303e98de3767d69c9805e7b26dcc
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 850c2002882be52e25f191f17785698deb5513c1
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94912
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All tests passed.
- Mesos ReviewBot
On Aug. 11, 2015, 12:30 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 12:30 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
> src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
> src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
> src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 2:30 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 11:58 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Remove hash_value functions, fix review issues.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
src/linux/cgroups.hpp 91ccfd046256d29504e93003de83c04f048c9b78
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 2:26 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 10, 2015, 10:51 a.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Changes
-------
Rebase master.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2
src/linux/cgroups.hpp a4a2cae8c0cf537b687897e56176aa44bf8bd21d
src/master/metrics.hpp c51887ee1e072a063d629a735a3c6a2212e616ef
src/messages/log.hpp 94e38c189703ff22c412b86429e052e942e75e75
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 1:52 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs (updated)
-----
include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
-----------------------------------------------------------
(Updated Aug. 7, 2015, 12:28 p.m.)
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-3217
https://issues.apache.org/jira/browse/MESOS-3217
Repository: mesos
Description
-------
Added std::hash template specializations.
Diffs
-----
include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
Diff: https://reviews.apache.org/r/37189/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37189: Added std::hash template specializations.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Aug. 7, 2015, 12:06 p.m., Alexander Rojas wrote:
> > include/mesos/type_utils.hpp, line 515
> > <https://reviews.apache.org/r/37189/diff/1/?file=1033607#file1033607line515>
> >
> > Perhaps add a summarized version of this comment into the code?
I've added a comment to every occurence to explain the static_cast. We should keep the other options mentioned in the former comment in mind.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94519
-----------------------------------------------------------
On Aug. 7, 2015, 12:28 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 12:28 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-3217
> https://issues.apache.org/jira/browse/MESOS-3217
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
> src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
> src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
> src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37189: Added std::hash template specializations.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94519
-----------------------------------------------------------
include/mesos/type_utils.hpp (line 515)
<https://reviews.apache.org/r/37189/#comment149142>
Perhaps add a summarized version of this comment into the code?
include/mesos/type_utils.hpp (line 555)
<https://reviews.apache.org/r/37189/#comment149143>
Sometimes is useful to use a large prime number as a seed. Don't know if this heuristic has any value here.
src/tests/containerizer.hpp (lines 56 - 59)
<https://reviews.apache.org/r/37189/#comment149144>
I think is better to use `boost::hash_combine` here.
- Alexander Rojas
On Aug. 7, 2015, 11:46 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37189/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 11:46 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added std::hash template specializations.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955
> src/linux/cgroups.hpp a651f3434b908b54d217117933740d52dbe50adf
> src/master/metrics.hpp 5e96a5f71d042592524fec2151f37de28e3008ea
> src/messages/log.hpp 4ddf35f9f5137eb7a9236dc9d1b4a73ba44bf61d
> src/module/manager.hpp cab67a8b1ee7164bb3cb2a8b24e1a6e05b40fd19
> src/module/manager.cpp 909ca56eea85d365cb9ebe1b3cce43051cabb670
> src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
> src/tests/fetcher_tests.cpp 81e70368f7a6164e9649964881aa5a688ef222e8
> src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84
>
> Diff: https://reviews.apache.org/r/37189/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>