You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2020/08/13 17:53:52 UTC

[kudu-CR] KUDU-2373: registered a flag validator with maintenance manager num threads 

Mahesh Reddy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16337


Change subject: KUDU-2373: registered a flag validator with maintenance_manager_num_threads
......................................................................

KUDU-2373: registered a flag validator with maintenance_manager_num_threads

Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16337/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16337

to look at the new patch set (#4).

Change subject: KUDU-2373: Registered a flag validator
......................................................................

KUDU-2373: Registered a flag validator

Validates gflag maintenance_manager_num_threads by ensuring
value cannot be set to 0 as this causes a failure during
server setup

Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16337/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 4
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16337 )

Change subject: KUDU-2373: Registered a flag validator
......................................................................

KUDU-2373: Registered a flag validator

Validates gflag maintenance_manager_num_threads by ensuring
value cannot be set to 0 as this causes a failure during
server setup

Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Reviewed-on: http://gerrit.cloudera.org:8080/16337
Tested-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Bankim Bhavsar: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 6
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2373: registered a flag validator with maintenance manager num threads

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16337

to look at the new patch set (#2).

Change subject: KUDU-2373: registered a flag validator with maintenance_manager_num_threads
......................................................................

KUDU-2373: registered a flag validator with maintenance_manager_num_threads

Validates flag so value cannot be set to 0 as this causes a failure

Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16337/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16337 )

Change subject: KUDU-2373: Registered a flag validator
......................................................................


Patch Set 5: Verified+1

> Patch Set 5: Verified-1
> 
> Build Failed 
> 
> http://jenkins.kudu.apache.org/job/kudu-gerrit/22238/ : FAILURE

Unrelated ASAN test failure. BuiltinNtpWithMiniChronydTest.SyncAndUnsyncReferenceServers


-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 19:05:37 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2373: registered a flag validator with maintenance manager num threads

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16337 )

Change subject: KUDU-2373: registered a flag validator with maintenance_manager_num_threads
......................................................................


Patch Set 2:

(2 comments)

You can run `make iwyu-fix` to fix the issue pointed by IWYU failure.

Were you able to the validator by manually adjusting the gflag to lets say 0.

http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG@7
PS2, Line 7: registered
Nit: Registered


http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc
File src/kudu/util/maintenance_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc@65
PS2, Line 65: DEFINE_validator(maintenance_manager_num_threads, [](const char* /*n*/, int32 v) { return v > 0; });
Nit: I guess tidy bot would have complained but this line does look long. If longer than 100 columns can you move the lambda function to next line?



-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Aug 2020 20:03:55 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2373: Registered a flag validator with maintenance manager num threads

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16337

to look at the new patch set (#3).

Change subject: KUDU-2373: Registered a flag validator with maintenance_manager_num_threads
......................................................................

KUDU-2373: Registered a flag validator with maintenance_manager_num_threads

Validates gflag maintenance_manager_num_threads by ensuring
value cannot be set to 0 as this causes a failure during
server setup

Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
---
M src/kudu/util/maintenance_manager.cc
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/16337/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has removed a vote on this change.

Change subject: KUDU-2373: Registered a flag validator
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16337 )

Change subject: KUDU-2373: Registered a flag validator
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 19:06:03 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2373: Registered a flag validator

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16337 )

Change subject: KUDU-2373: Registered a flag validator
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16337/2//COMMIT_MSG@7
PS2, Line 7: Registered
> Nit: Registered
Done


http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc
File src/kudu/util/maintenance_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16337/2/src/kudu/util/maintenance_manager.cc@65
PS2, Line 65: TAG_FLAG(maintenance_manager_num_threads, stable);
> Nit: I guess tidy bot would have complained but this line does look long. I
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16337
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I705c3ebdcd1e961e6723f044e8abda8d9004089d
Gerrit-Change-Number: 16337
Gerrit-PatchSet: 5
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Aug 2020 17:33:25 +0000
Gerrit-HasComments: Yes