[GitHub] [superset] michael-s-molina commented on a change in pull request #16992: feat(native_filter_migration): add transition mode

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r734457700



##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
   centered?: boolean;
   footer?: React.ReactNode;
   wrapProps?: object;
+  maskStyle?: object;

Review comment:
       The problem with this approach is that it will create a different interaction than the rest of the application. If we want to allow navigation while a modal is open, we should do it globally and probably in a separate PR. If the user clicks on Cancel and stays in the current dashboard, he can always navigate later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org