[GitHub] incubator-brooklyn pull request: Windows scripting - documentation...

[sjcorbett <gi...@git.apache.org>]

Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/964#discussion_r42352012
  
    --- Diff: docs/guide/yaml/winrm/index.md ---
    @@ -148,12 +148,26 @@ circumstances. It is therefore advisable to follow the guidelines below.
     Upload this (e.g. by including it in the `files.preinstall` configuration). For the configuration
     of the given command, execute the file.*
     
    -For Powershell files, consider including the line below at the start of the file. 
    -Without this, it defaults to "continue" which means that if a command in the Powershell file fails
    -then it will continue and return an exit code based on only the final command.
    +When you have a command inside the powershell script which want to report its non zero exiting, 
    +please consider adding a check for its exit code after it.
    +Example:
    +
    +    C:\install.exe
    +    If ($lastexitcode -ne 0) {
    +        exit $lastexitcod
    --- End diff --
    
    Typo: `lastexitcod`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---