You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/12/16 23:50:18 UTC

[jira] Created: (THRIFT-653) Fix toString method for enums

Fix toString method for enums
-----------------------------

                 Key: THRIFT-653
                 URL: https://issues.apache.org/jira/browse/THRIFT-653
             Project: Thrift
          Issue Type: Improvement
          Components: Compiler (Java)
    Affects Versions: 0.2
            Reporter: Bryan Duxbury
            Assignee: Bryan Duxbury
            Priority: Trivial
             Fix For: 0.3


Now that enums are actually enums, their toStrings are acceptable in the overall struct toString. We should remove the special case we built in for this in the past.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-653) Fix toString method for enums

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-653:
---------------------------------

    Attachment: thrift-653.patch

I think this should do it.

> Fix toString method for enums
> -----------------------------
>
>                 Key: THRIFT-653
>                 URL: https://issues.apache.org/jira/browse/THRIFT-653
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>             Fix For: 0.3
>
>         Attachments: thrift-653.patch
>
>
> Now that enums are actually enums, their toStrings are acceptable in the overall struct toString. We should remove the special case we built in for this in the past.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-653) Fix toString method for enums

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-653:
---------------------------------

    Patch Info: [Patch Available]

> Fix toString method for enums
> -----------------------------
>
>                 Key: THRIFT-653
>                 URL: https://issues.apache.org/jira/browse/THRIFT-653
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>             Fix For: 0.3
>
>         Attachments: thrift-653.patch
>
>
> Now that enums are actually enums, their toStrings are acceptable in the overall struct toString. We should remove the special case we built in for this in the past.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-653) Fix toString method for enums

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-653.
--------------------------------

    Resolution: Fixed

I just committed this.

> Fix toString method for enums
> -----------------------------
>
>                 Key: THRIFT-653
>                 URL: https://issues.apache.org/jira/browse/THRIFT-653
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>    Affects Versions: 0.2
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Trivial
>             Fix For: 0.3
>
>         Attachments: thrift-653.patch
>
>
> Now that enums are actually enums, their toStrings are acceptable in the overall struct toString. We should remove the special case we built in for this in the past.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.