You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/17 09:31:09 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17062: [build][sql] Make pulsar-trino-disto self-contained

tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r947676029


##########
buildtools/src/main/resources/pulsar/checkstyle.xml:
##########
@@ -39,6 +39,9 @@ page at http://checkstyle.sourceforge.net/config.html -->
         <property name="max" value="120"/>
         <property name="severity" value="error"/>
 
+        <!-- Checks only for Java files. -->
+        <property name="fileExtensions" value="java"/>

Review Comment:
   OK. I include this change in the patch because after I move config files under the module, this rule takes effect and reports failure. I can do it in a separate PR though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org