[GitHub] [incubator-devlake] likyh commented on a diff in pull request #2259: Ref gitlab conn id issue 5

[GitBox <gi...@apache.org>]

likyh commented on code in PR #2259:
URL: https://github.com/apache/incubator-devlake/pull/2259#discussion_r901303438


##########
plugins/gitlab/tasks/issue_extractor.go:
##########
@@ -134,7 +134,8 @@ func ExtractApiIssues(taskCtx core.SubTaskContext) error {
 				set of data to be process, for example, we process JiraIssues by Board
 			*/
 			Params: GitlabApiParams{
-				ProjectId: data.Options.ProjectId,
+				ProjectId:    data.Options.ProjectId,
+				ConnectionId: data.Options.ConnectionId,

Review Comment:
   use CreateRawDataSubTaskArgs?



##########
plugins/gitlab/tasks/issue_convertor.go:
##########
@@ -94,7 +88,7 @@ func ConvertIssues(taskCtx core.SubTaskContext) error {
 				domainIssue.Status = ticket.DONE
 			}
 			boardIssue := &ticket.BoardIssue{
-				BoardId: boardIdGen.Generate(projectId),
+				BoardId: boardIdGen.Generate(data.Options.ConnectionId, projectId),

Review Comment:
   maybe can replace `projectId` with `data.Options.ProjectId` to keep code consisont like above (Line 49).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org