You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by CMoH <gi...@git.apache.org> on 2015/07/17 17:44:00 UTC
[GitHub] incubator-brooklyn pull request: Rename org apache
GitHub user CMoH opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/755
Rename org apache
Rename more packages to add the org.apache prefix.
I have run mvn clean install (which runs the unit tests). For some reason running mvn test alone fails with the following error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:copy (copy) on project brooklyn-software-base: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187. -> [Help 1]
Maybe some dependencies were missed?
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CMoH/incubator-brooklyn rename_org_apache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit a1613a60401ddaa8e7e5cd84c339f378e94ccab6
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-16T08:27:15Z
brooklyn-rest-client: add org.apache package prefix
commit 40b2ba875f86288b82a29d94755f0594e4608d56
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-16T12:48:59Z
brooklyn-jsgui: add org.apache package prefix
commit 743e8597de18ab07390e83b4dfc993c0a84a8f44
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-16T15:10:16Z
brooklyn-dist: add org.apache package prefix
commit 4959bb430682bc2176afdda74879a59ef4b66098
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-16T15:35:57Z
brooklyn-cli: add org.apache package prefix
Also update dependent scripts/classes in brooklyn-archetype-quickstart,
brooklyn-example-simple-nosql-cluster and brooklyn-dist.
commit 73eef446a7b04e174508271423856cd5c0a6f864
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-16T16:11:03Z
brooklyn-launcher: add org.apache package prefix
Also update dependent projects.
commit 1c83d3824c18a89a249d18ee057080994829dc54
Author: Ciprian Ciubotariu <ch...@gmx.net>
Date: 2015-07-17T09:18:47Z
brooklyn-storage-hazelcast: add org.apache package prefix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rename base package from brooklyn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/755
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rename base package from brooklyn...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/755#issuecomment-127718283
Looks good. Tested and reviewed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rename base package from brooklyn...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/755#issuecomment-124329433
Thanks @CMoH
The asfbot build failure shows:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile (default-testCompile) on project brooklyn-qa: Compilation failure: Compilation failure:
[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests/usage/qa/src/test/java/brooklyn/qa/brooklynnode/SoftlayerObtainPrivateLiveTest.java:[41,24] error: package brooklyn.launcher does not exist
[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests/usage/qa/src/test/java/brooklyn/qa/brooklynnode/SoftlayerObtainPrivateLiveTest.java:[94,12] error: cannot find symbol
[ERROR] symbol: class BrooklynLauncher
[ERROR] location: class SoftlayerObtainPrivateLiveTest
[ERROR] /home/jenkins/jenkins-slave/workspace/incubator-brooklyn-pull-requests/usage/qa/src/test/java/brooklyn/qa/brooklynnode/SoftlayerObtainPrivateLiveTest.java:[104,19] error: cannot find symbol
[ERROR] -> [Help 1]
Was that file missed in the `qa` package when the others were renamed?
https://github.com/apache/incubator-brooklyn/blob/master/usage/qa/src/test/java/brooklyn/qa/brooklynnode/SoftlayerObtainPrivateLiveTest.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Rename base package from brooklyn...
Posted by CMoH <gi...@git.apache.org>.
Github user CMoH commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/755#issuecomment-124438074
I believe it is due to more PRs applied to the the master branch.
Now that it seems you have started clearing the PR queue, I'll rebase the branch later on so it will be working at the beginning of next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---