You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ti...@apache.org on 2015/04/16 09:55:39 UTC
[1/3] mesos git commit: Added -Wno-unused-local-typedef for clang 3.6.
Repository: mesos
Updated Branches:
refs/heads/master 1f97b2844 -> f6620f851
Added -Wno-unused-local-typedef for clang 3.6.
Review: https://reviews.apache.org/r/32749
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f6620f85
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f6620f85
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f6620f85
Branch: refs/heads/master
Commit: f6620f851f635b3346c6ebf878152f38b3932ad9
Parents: 06dd75c
Author: Cody Maloney <co...@mesosphere.io>
Authored: Wed Apr 15 19:47:44 2015 +0200
Committer: Till Toenshoff <to...@me.com>
Committed: Thu Apr 16 09:54:23 2015 +0200
----------------------------------------------------------------------
configure.ac | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/f6620f85/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index 868c041..6346db9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -575,6 +575,33 @@ if test "x$CLANG" = "xno"; then
if test "x$is_gxx47" = "xyes"; then
AC_MSG_ERROR([Unable to build with g++-4.7 due to missing C++11 features])
fi
+
+# CLANG=yes
+else
+
+ # Check if -Wno-unused-local-typedef is needed by checking a sample
+ # compilation which contains a local unused typedef.
+ # This is needed because Boost 1.53.0 fails to compile with upstream
+ # Clang 3.6 without -Wno-unused-local-typedef. Apple LLVM based on
+ # Clang 3.6 doesn't have the same behavior.
+ AC_LANG_PUSH([C++])
+ AC_COMPILE_IFELSE(
+ [AC_LANG_SOURCE([[
+ #pragma clang diagnostic error "-Wunused-local-typedef"
+
+ int foo()
+ {
+ typedef int return_type;
+ return 5;
+ }
+ ]])],
+ [warn_local_typedefs=no], [warn_local_typedefs=yes])
+ AC_LANG_POP([C++])
+
+ if test "x$warn_local_typedefs" = "xyes"; then
+ AC_MSG_NOTICE([Disabling warnings about unused local typedefs])
+ CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedef"
+ fi
fi
[3/3] mesos git commit: libprocess: Placed noreturn attribute
correctly for C11.
Posted by ti...@apache.org.
libprocess: Placed noreturn attribute correctly for C11.
Places bundled libev noreturn attribute correctly for C11.
The bundled libev uses different noreturn attributes based on whether
it is compiled with C11 or not. The C11 codepath places the noreturn
attribute in an incorrect (but accepted by GCC) location. Move it to
the standard location which is accepted by all supported compilers.
Review: https://reviews.apache.org/r/32747
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/6da1d4ec
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/6da1d4ec
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/6da1d4ec
Branch: refs/heads/master
Commit: 6da1d4ec25e7749bae8680ce62cb22b5a73fa047
Parents: 1f97b28
Author: Cody Maloney <co...@mesosphere.io>
Authored: Wed Apr 15 19:46:15 2015 +0200
Committer: Till Toenshoff <to...@me.com>
Committed: Thu Apr 16 09:54:23 2015 +0200
----------------------------------------------------------------------
3rdparty/libprocess/3rdparty/libev-4.15.patch | 12 ++++++++++++
1 file changed, 12 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/6da1d4ec/3rdparty/libprocess/3rdparty/libev-4.15.patch
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/libev-4.15.patch b/3rdparty/libprocess/3rdparty/libev-4.15.patch
index 2b94532..bbd83e6 100644
--- a/3rdparty/libprocess/3rdparty/libev-4.15.patch
+++ b/3rdparty/libprocess/3rdparty/libev-4.15.patch
@@ -9,3 +9,15 @@ diff -rupN libev-4.15/ev.h libev-4.15-patched/ev.h
+# define EV_CHILD_ENABLE 0
#endif
#endif
+
+diff -rupN libev-4.15/ev.c libev-4.15-patched/ev.c
+--- libev-4.15/ev.c 2013-03-01 03:10:48.000000000 -0800
++++ libev-4.15-patched/ev.c 2015-03-31 18:32:07.910991755 -0700
+@@ -967,7 +967,7 @@ ecb_inline uint64_t ecb_rotr64 (uint64_t
+ #define ecb_unreachable() __builtin_unreachable ()
+ #else
+ /* this seems to work fine, but gcc always emits a warning for it :/ */
+- ecb_inline void ecb_unreachable (void) ecb_noreturn;
++ ecb_inline ecb_noreturn void ecb_unreachable (void);
+ ecb_inline void ecb_unreachable (void) { }
+ #endif
[2/3] mesos git commit: libprocess: Added -Wno-unused-local-typedef
for clang 3.6
Posted by ti...@apache.org.
libprocess: Added -Wno-unused-local-typedef for clang 3.6
Review: https://reviews.apache.org/r/32748
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/06dd75ce
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/06dd75ce
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/06dd75ce
Branch: refs/heads/master
Commit: 06dd75ce37ce3ba8466c3a3d90e0d12c0a308f4f
Parents: 6da1d4e
Author: Cody Maloney <co...@mesosphere.io>
Authored: Wed Apr 15 19:47:11 2015 +0200
Committer: Till Toenshoff <to...@me.com>
Committed: Thu Apr 16 09:54:23 2015 +0200
----------------------------------------------------------------------
3rdparty/libprocess/configure.ac | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/06dd75ce/3rdparty/libprocess/configure.ac
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/configure.ac b/3rdparty/libprocess/configure.ac
index a126ecf..723777d 100644
--- a/3rdparty/libprocess/configure.ac
+++ b/3rdparty/libprocess/configure.ac
@@ -659,6 +659,33 @@ if test "x$CLANG" = "xno"; then
if test "x$is_gxx47" = "xyes"; then
AC_MSG_ERROR([Unable to build with g++-4.7 due to missing C++11 features])
fi
+
+# CLANG=yes
+else
+
+ # Check if -Wno-unused-local-typedef is needed by checking a sample
+ # compilation which contains a local unused typedef.
+ # This is needed because Boost 1.53.0 fails to compile with upstream
+ # Clang 3.6 without -Wno-unused-local-typedef. Apple LLVM based on
+ # Clang 3.6 doesn't have the same behavior.
+ AC_LANG_PUSH([C++])
+ AC_COMPILE_IFELSE(
+ [AC_LANG_SOURCE([[
+ #pragma clang diagnostic error "-Wunused-local-typedef"
+
+ int foo()
+ {
+ typedef int return_type;
+ return 5;
+ }
+ ]])],
+ [warn_local_typedefs=no], [warn_local_typedefs=yes])
+ AC_LANG_POP([C++])
+
+ if test "x$warn_local_typedefs" = "xyes"; then
+ AC_MSG_NOTICE([Disabling warnings about unused local typedefs])
+ CXXFLAGS="${CXXFLAGS} -Wno-unused-local-typedef"
+ fi
fi