You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:23:56 UTC
[GitHub] [flink] tillrohrmann commented on a change in pull request #12995: [FLINK-18517][k8s][release-1.10] Bump fabric8 version from 4.5.2 to 4.9.2
tillrohrmann commented on a change in pull request #12995:
URL: https://github.com/apache/flink/pull/12995#discussion_r461433953
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
I think we still bundle `com.github.mifmif:generex:1.0.2`. Hence we cannot remove this entry.
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
You are right. If it worked before, why do we need to bundle `com.github.mifmif`? If we don't need it, then we can also remove the shading of this dependency.
##########
File path: flink-kubernetes/src/main/resources/META-INF/NOTICE
##########
@@ -10,14 +10,14 @@ This project bundles the following dependencies under the Apache Software Licens
- com.fasterxml.jackson.core:jackson-core:2.10.1
- com.fasterxml.jackson.core:jackson-databind:2.10.1
- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.10.1
-- com.github.mifmif:generex:1.0.2
Review comment:
If we don't use this code, then we don't need to bundle it in the resulting artifact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org