You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Dmitry Repchevsky (JIRA)" <ji...@apache.org> on 2011/03/31 11:39:06 UTC
[jira] [Created] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
---------------------------------------------------------------------------------------------------
Key: XMLSCHEMA-11
URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
Project: XmlSchema
Issue Type: Question
Affects Versions: XmlSchema 2.0
Environment: Java :-)
Reporter: Dmitry Repchevsky
XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Updated] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Dmitry Repchevsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Repchevsky updated XMLSCHEMA-11:
---------------------------------------
Attachment: fnroyOcPjyUAAAAASUVORK5CYII=
I am not sure this is a good idea for the 2.0 version... :-(
XmlSchemaObject is an abstract class so changing
XmlSchemaChoice.getItems() return type may break compatibility.
I would prefer to make XmlSchemaChoiceMember inherit XmlSchemaObjectBase
now and leave
public List<XmlSchemaChoiceMember> getItems() for future.
Probably it is possible to trick with generics:
public <T extends XmlSchemaObjectBase> List<T> getItems()
this way both would work:
List<XmlSchemaChoiceMember> members = choice.getItems();
List<XmlSchemaObject> objects = choice.getItems();
Kind regards,
Dmitry
--
------------------------------------------------------------------------
Barcelona Supercomputing Center National Institute of Bioinformatics,
Life Science, Computational Node 6
Nexus II, Jordi Girona 29, 08034 Barcelona, Spain
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
> Attachments: fnroyOcPjyUAAAAASUVORK5CYII=
>
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022358#comment-13022358 ]
Benson Margulies commented on XMLSCHEMA-11:
-------------------------------------------
I agree. Care to post a patch?
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Updated] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Dmitry Repchevsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dmitry Repchevsky updated XMLSCHEMA-11:
---------------------------------------
Priority: Trivial (was: Major)
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030526#comment-13030526 ]
Benson Margulies commented on XMLSCHEMA-11:
-------------------------------------------
True, I missed it altogether. More thought called for.
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
> Attachments: fnroyOcPjyUAAAAASUVORK5CYII=
>
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Dmitry Repchevsky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030654#comment-13030654 ]
Dmitry Repchevsky commented on XMLSCHEMA-11:
--------------------------------------------
OMG I didn't realize that it's in utils package.
So probably there is another problem here, because all XmlSchemaObjects
implement XmlSchemaObjectBase...
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
> Attachments: fnroyOcPjyUAAAAASUVORK5CYII=
>
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Benson Margulies (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030771#comment-13030771 ]
Benson Margulies commented on XMLSCHEMA-11:
-------------------------------------------
I fear that there's less to this than meets the eye; that I (mis)used the 'util' package as a catch-all home for shared code when I did 2.0.
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
> Attachments: fnroyOcPjyUAAAAASUVORK5CYII=
>
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org
[jira] [Commented] (XMLSCHEMA-11) XmlSchemaChoice.getItems() should
probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/XMLSCHEMA-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030524#comment-13030524 ]
Andreas Veithen commented on XMLSCHEMA-11:
------------------------------------------
As already pointed out in [1], having interfaces in org.apache.ws.commons.schema extend an interface in org.apache.ws.commons.schema.utils doesn't sound correct.
BTW, Benson, you never replied to that objection.
[1] http://markmail.org/message/6ha4ktfeyme43mul
> XmlSchemaChoice.getItems() should probably return XmlSchemaChoiceMember instead of XmlSchemaObject.
> ---------------------------------------------------------------------------------------------------
>
> Key: XMLSCHEMA-11
> URL: https://issues.apache.org/jira/browse/XMLSCHEMA-11
> Project: XmlSchema
> Issue Type: Question
> Affects Versions: XmlSchema 2.0
> Environment: Java :-)
> Reporter: Dmitry Repchevsky
> Priority: Trivial
> Labels: API, changes
> Attachments: fnroyOcPjyUAAAAASUVORK5CYII=
>
>
> XmlSchemaSequence.getItems() returns XmlSchemaSequenceMember. IMHO XmlSchemaChoice.getItems() should return XmlSchemaChoiceMember.
> Also XmlSchemaChoiceMember could inherit XmlSchemaObjectBase (as XmlSchemaSequenceMember does), so both XmlSchemaSequence.getItems() and XmlSchemaChoice.getItems() will return XmlSchemaObjectBase type that facilitates parsing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org