You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/18 23:12:34 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35830: [SPARK-38597][K8S][INFRA] Enable K8S integration tests in Github Action

dongjoon-hyun commented on a change in pull request #35830:
URL: https://github.com/apache/spark/pull/35830#discussion_r830398887



##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -268,6 +268,22 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
     </td>
     <td></td>
   </tr>
+  <tr>
+    <td><code>spark.kubernetes.test.driver.cpu</code></td>

Review comment:
       This should be `cores` because you are setting `cores` via `spark.kubernetes.driver.request.cores`.

##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -268,6 +268,22 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
     </td>
     <td></td>
   </tr>
+  <tr>
+    <td><code>spark.kubernetes.test.driver.cpu</code></td>
+    <td>
+      Set cpu resource for each driver pod in test, this is currently only for GA Test (cpu resource limited),
+      it's not recommended for other scenarios.
+    </td>
+    <td></td>
+  </tr>
+  <tr>
+    <td><code>spark.kubernetes.test.executor.cpu</code></td>

Review comment:
       ditto.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org