You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 17:07:57 UTC

[GitHub] [superset] mayurnewase commented on a diff in pull request #21729: fix: allow adhoc columns in non-aggregate query

mayurnewase commented on code in PR #21729:
URL: https://github.com/apache/superset/pull/21729#discussion_r1016904126


##########
superset/connectors/sqla/models.py:
##########
@@ -119,6 +119,7 @@
 from superset.superset_typing import (
     AdhocColumn,
     AdhocMetric,
+    Column as ColumnTyping,

Review Comment:
   @john-bodley there is import of Column from sqlalchemy on line 50.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org