You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/03/31 01:46:14 UTC
[GitHub] [calcite] JiahuiJiang opened a new pull request #1893: Ignore more
IntelliJ system files
JiahuiJiang opened a new pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893
Also ignore calcite.ipr and calcite.iws
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi commented on a change in pull request #1893: Ignore
more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r400887048
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
> They are the config files generated for me when I run "./gradlew idea" :D
We should probably want to make `gradlew idea` throw exception. Native IDEA project import should be preferred rather than `gradlew idea`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] vlsi commented on a change in pull request #1893: Ignore
more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r401818955
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
Well, if you happen to have ipr and iws files, we can merge the PR.
However, I'm using IDEA, and I find it is easier to use regular project import rather than trying to use other approaches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] JiahuiJiang commented on a change in pull request #1893:
Ignore more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
JiahuiJiang commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r401730247
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
I see, didn't realize the native import is the preferred way and there is already 'idea-ext' in the project.
Closing this PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] JiahuiJiang commented on a change in pull request #1893:
Ignore more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
JiahuiJiang commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r400873274
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
They are the config files generated for me when I run "./gradlew idea" :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1893:
Ignore more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r400662557
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
Found some doc about the file format: https://www.jetbrains.com/help/idea/creating-and-managing-projects.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] JiahuiJiang closed pull request #1893: Ignore more
IntelliJ system files
Posted by GitBox <gi...@apache.org>.
JiahuiJiang closed pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [calcite] danny0405 commented on a change in pull request #1893:
Ignore more IntelliJ system files
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1893: Ignore more IntelliJ system files
URL: https://github.com/apache/calcite/pull/1893#discussion_r400659941
##########
File path: .gitignore
##########
@@ -31,6 +31,8 @@
/example/*/out
.idea
*.iml
+*.ipr
+*.iws
Review comment:
I didn't found any files with such pattern under current code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services