You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bsf-dev@jakarta.apache.org by se...@apache.org on 2009/03/25 16:53:31 UTC

svn commit: r758317 - /jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java

Author: sebb
Date: Wed Mar 25 15:53:29 2009
New Revision: 758317

URL: http://svn.apache.org/viewvc?rev=758317&view=rev
Log:
Ignore attempt to set attribute for null global scope

Modified:
    jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java

Modified: jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java
URL: http://svn.apache.org/viewvc/jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java?rev=758317&r1=758316&r2=758317&view=diff
==============================================================================
--- jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java (original)
+++ jakarta/bsf/trunk/bsf3/bsf-api/src/main/java/javax/script/SimpleScriptContext.java Wed Mar 25 15:53:29 2009
@@ -53,6 +53,8 @@
     /** The writer to be used for displaying error output from scripts */
     protected Writer errorWriter;
 
+    // N.B. These fields are mandated as protected by the JSR-223 spec.
+    
     /** Immutable list of scopes returned by {@link #getScopes()}*/
     private static final List SCOPES = 
         Collections.unmodifiableList(
@@ -168,8 +170,6 @@
             case GLOBAL_SCOPE:
                 if (globalScope != null) {
                     globalScope.put(name, value);
-                } else {
-                    throw new IllegalArgumentException("Global scope is null");// TODO is this correct?
                 }
                 break;
             default:



---------------------------------------------------------------------
To unsubscribe, e-mail: bsf-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bsf-dev-help@jakarta.apache.org