You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/19 14:03:28 UTC

[GitHub] [airflow] eladkal opened a new issue, #23081: Misleading scheduler health message when using SequentialExecutor

eladkal opened a new issue, #23081:
URL: https://github.com/apache/airflow/issues/23081

   ### Body
   
   In the UI we have a message that warns in case the scheduler isn't running:
   `The scheduler does not appear to be running. Last heartbeat was received X minutes ago.`
   https://github.com/apache/airflow/blame/5144bedcee76466a79eea0b2b6137e5899dc73bd/airflow/www/templates/airflow/main.html#L60-L71
   
   This message however is confusing for `SequentialExecutor`.
   In `SequentialExecutor` we can run only 1 task so while a task is running the scheduler is not sending health checks which results in this message but it make sense that there is no heartbeat because there is a task that occupy the slot.
   
   My suggestion is to make the message be conditional 
   
   in case of Sqlite / Sequential executor + no active runs -> It's OK to show the message if scheduler is not live.
   in case of Sqlite / Sequential executor + active run -> Message should not appear.
   
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #23081: Misleading scheduler health message when using SequentialExecutor

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #23081:
URL: https://github.com/apache/airflow/issues/23081#issuecomment-1102700967

   We should move this logic from `main.html` and handle it inside the webserver in `views.py` and pass a single variable of `is_scheduler_running` to the UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org