You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/03/31 11:16:01 UTC
Review Request 58105: Ambari Log Search Web - fix some build npm
errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58105/
-----------------------------------------------------------
Review request for Ambari, Aleksandr Kovalenko, Miklos Gergely, and Robert Nettleton.
Bugs: AMBARI-20644
https://issues.apache.org/jira/browse/AMBARI-20644
Repository: ambari
Description
-------
Currently we have some build errors with npm:
[ERROR] npm WARN package.json ambari-logsearch-web@0.5.0 No repository field.
[ERROR] npm WARN package.json ambari-logsearch-web@0.5.0 No README data
[ERROR] npm WARN package.json ambari-logsearch-web@0.5.0 license should be a valid SPDX license expression
[ERROR] npm WARN deprecated gulp-minify-css@1.2.4: Please use gulp-clean-css
[ERROR] npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
[ERROR] npm WARN deprecated node-uuid@1.4.8: Use uuid module instead
[ERROR] npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
[ERROR] npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
[ERROR] npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
Most of them can be fixed, by editing package.json properly (I skiped the nested dependencies as grunt use some of them), so the result will be after this patch:
[ERROR] npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
[ERROR] npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls
graceful-fs' to find it in the tree.
[ERROR] npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
[ERROR] npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
Diffs
-----
ambari-logsearch/ambari-logsearch-web/package.json 9dad560
Diff: https://reviews.apache.org/r/58105/diff/1/
Testing
-------
done.
Thanks,
Oliver Szabo