[GitHub] [pulsar] Jason918 commented on a diff in pull request #17470: [doc] Fix the release process and regenerate the table of contents

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #17470:
URL: https://github.com/apache/pulsar/pull/17470#discussion_r962705654


##########
wiki/release/release-process.md:
##########
@@ -382,13 +391,13 @@ This is alternative to A. when the user has access to apachepulsar org in hub.do
 
 4. Once it is merged, the chart will be automatically released to Github releases at https://github.com/apache/pulsar-helm-chart and updated to https://pulsar.apache.org/charts.
 
-## 12. Publish Python Clients
+## 11. Publish Python Clients

Review Comment:
   It's better to swap step 11 and 12.



##########
wiki/release/release-process.md:
##########
@@ -412,35 +421,19 @@ $ twine upload pulsar_client-*.whl
 
 ### MacOS
 
-> **NOTES**
->
-> You need to install following softwares before proceeding:
->
-> - [VirtualBox](https://www.virtualbox.org/)
-> - [VirtualBox Extension Pack]
-> - [Vagrant](https://www.vagrantup.com/)
-> - [Vagrant-scp](https://github.com/invernizzi/vagrant-scp)
->
-> And make sure your laptop have enough disk spaces (> 30GB) since the build scripts
-> will download MacOS images, launch them in VirtualBox and build the python
-> scripts.
-
-Build the python scripts.
+There is a script that builds and packages the Python client inside Docker images.
 
 ```shell
-$ cd pulsar-client-cpp/python/pkg/osx/
-$ ./generate-all-wheel.sh v2.X.Y
+$ pulsar-client-cpp/python/build-mac-wheels.sh
 ```
 
 The wheel files will be generated at each platform directory under `pulsar-client-cpp/python/pkg/osx/`.
 Then you can run `twin upload` to upload those wheel files.
 
-If you don't have enough spaces, you can build the python wheel file platform by platform and remove the images under `~/.vagrant.d/boxes` between each run.
-
-## 13. Publish MacOS libpulsar package
+## 12. Publish MacOS libpulsar package

Review Comment:
   This is similar with Helm Chart, it can be skipped if the major version number is not latest.



##########
wiki/release/release-process.md:
##########
@@ -467,11 +460,18 @@ cp pulsar-broker/target/docs/*.json site2/website/static/swagger/2.X.0
 ```
 Send out a PR request for review.
 
-## 16. Write release notes
+## 15. Write release notes
+
+Check the milestone in Github associated with the release.
+https://github.com/apache/pulsar/milestones?closed=1
+
+In the release item, add the list of most important changes that happened in the
+release and a link to the associated milestone, with the complete list of all the
+changes.

Review Comment:
   I think we should just remove this part. There is no release item in the link.



##########
wiki/release/release-process.md:
##########
@@ -333,7 +341,7 @@ select the staging repository associated with the RC candidate that was approved
 will be like `orgapachepulsar-XYZ`. Select the repository and click on "Release". Artifacts
 will now be made available on Maven central.
 
-## 10. Publish Docker Images
+## 9. Publish Docker Images

Review Comment:
   Maybe we should add the list of committer with access to apachepulsar org?



##########
wiki/release/release-process.md:
##########
@@ -303,17 +287,41 @@ https://github.com/apache/pulsar/releases/tag/v2.X.0-candidate-1
 Pulsar's KEYS file containing PGP keys we use to sign the release:
 https://dist.apache.org/repos/dist/dev/pulsar/KEYS
 
+Docker images:

Review Comment:
   If we add this part. Let's move the first part of 9.A forward, before this Vote. And remove 9.B.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org