You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Kevin Watters (JIRA)" <ji...@apache.org> on 2018/05/15 14:50:00 UTC
[jira] [Commented] (SOLR-12328) Adding graph json facet domain
change
[ https://issues.apache.org/jira/browse/SOLR-12328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475938#comment-16475938 ]
Kevin Watters commented on SOLR-12328:
--------------------------------------
Hey Dan , this looks pretty awesome. One comment, If the traversal filter is null/empty, I don't think the default match all query is needed. So, in the GraphField class, I think you can probably get rid of that null check and default value for the traversal filter.
> Adding graph json facet domain change
> -------------------------------------
>
> Key: SOLR-12328
> URL: https://issues.apache.org/jira/browse/SOLR-12328
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Affects Versions: 7.3
> Reporter: Daniel Meehl
> Priority: Major
> Attachments: SOLR-12328.patch
>
>
> Json facets now support join queries via domain change. I've made a relatively small enhancement to add graph to the mix. I'll attach a patch for your viewing. I'm hoping this can be merged into solr proper. Please let me know if there are any problems/changes/requirements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org