You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2015/12/22 08:48:44 UTC

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/564

    adding shadow to navbar if noteActionBar is not present

    ### What is this PR for?
    This PR adds shadow to navbar if noteActionBar is not present
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    N/A
    
    ### Is there a relevant Jira issue?
    N/A
    
    
    ### Screenshots (if appropriate)
    
    Before:
    <img width="1440" alt="screen shot 2015-12-22 at 1 05 54 pm" src="https://cloud.githubusercontent.com/assets/674497/11950315/4b033d14-a8ad-11e5-93c1-9be5a72c4718.png">
    
    After:
    <img width="1440" alt="screen shot 2015-12-22 at 1 06 17 pm" src="https://cloud.githubusercontent.com/assets/674497/11950314/4b02dcac-a8ad-11e5-869f-7a752f48f050.png">


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin navbarShadow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/564.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #564
    
----
commit ffb64ec54347001d131e165f3b938e35902f64fc
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2015-12-22T07:47:46Z

    adding shadow to navbar if noteActionBar is not present

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/564#issuecomment-167920636
  
    Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/564#issuecomment-166794598
  
    I think it could be better to fix the interpreter page Action bar instead of adding another shadow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/564


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: adding shadow to navbar if noteAc...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/564#issuecomment-166803095
  
    I think shadow generally looks good on top bar / nav bar. 
    Depending upon resolution after having 18-20 notebooks scroll bar shows up on homepage as well. Hence, thought it would be a good idea to have shadow over there as well.
    
    <img width="1440" alt="screen shot 2015-12-23 at 10 20 12 am" src="https://cloud.githubusercontent.com/assets/674497/11971184/f9c24992-a95e-11e5-9f90-4611fb3174dc.png">



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---