You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/04 06:53:32 UTC
[GitHub] zeppelin pull request #2219: [ZEPPELIN-2348] Line chart setting is not rende...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2219
[ZEPPELIN-2348] Line chart setting is not rendered (branch-0.7)
### What is this PR for?
Line chart setting is not rendered.
### What type of PR is it?
[Bug Fix]
### Todos
None.
### What is the Jira issue?
[ZEPPELIN-2348](https://issues.apache.org/jira/browse/ZEPPELIN-2348)
### How should this be tested?
1. Open the default line chart's setting
2. Check checkboxes for options.
### Screenshots (if appropriate)
#### After
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2348/line-chart-setting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2219.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2219
----
commit 42165879af92af37079d064d2902218a55fe23b1
Author: 1ambda <1a...@gmail.com>
Date: 2017-04-04T06:44:28Z
fix: overwriting trSetting
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/2219
@1ambda @Leemoonsoo I also couldn't reproduce in branch-0.7. But I think the code should be modified!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2219
@Leemoonsoo I failed to reproduce it in branch-0.7, so it's ok to just close this PR if it's save. But code looks like buggy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2219
@1ambda This PR has merged but @asfgit didn't close it. Could you close it manually?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2219: [ZEPPELIN-2348] Line chart setting is not rendered (br...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2219
Merge this to branch-0.7 along with #2218
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2219: [ZEPPELIN-2348] Line chart setting is not rende...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2219
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---